Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add pushdown for ShowStmt and implement for show columns #31742

Merged
merged 14 commits into from
Jan 20, 2022
Merged

*: add pushdown for ShowStmt and implement for show columns #31742

merged 14 commits into from
Jan 20, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 17, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #29910

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 17, 2022
@hawkingrei hawkingrei added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 17, 2022
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 17, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jan 17, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ce5e622dd749749aeb5ba66bbce7c2570e306bdb

@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei hawkingrei force-pushed the add_show_push_predicate branch 5 times, most recently from 031b21f to d05d943 Compare January 18, 2022 07:32
@hawkingrei hawkingrei changed the title *: add pushdown for show columns *: *: add pushdown for ShowStmt and implement for show columns Jan 18, 2022
@ti-chi-bot ti-chi-bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue labels Jan 18, 2022
@hawkingrei hawkingrei changed the title *: *: add pushdown for ShowStmt and implement for show columns *: add pushdown for ShowStmt and implement for show columns Jan 18, 2022
@hawkingrei
Copy link
Member Author

/run-mysql-test

@hawkingrei hawkingrei force-pushed the add_show_push_predicate branch 6 times, most recently from 884af62 to ccae839 Compare January 18, 2022 09:38
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 18, 2022
@hawkingrei
Copy link
Member Author

/run-mysql-test

@hawkingrei
Copy link
Member Author

/run-check_dev

@hawkingrei
Copy link
Member Author

/run-unit-test

3 similar comments
@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei
Copy link
Member Author

/run-check_dev_2

@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei hawkingrei added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Jan 20, 2022
@hawkingrei
Copy link
Member Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit ad1c5b5 into pingcap:master Jan 20, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 20, 2022
@hawkingrei @ti-srebot
cherry pick pingcap#31742 to release-5.4
03d58e0 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jan 20, 2022
Merged
12 tasks
@hawkingrei hawkingrei deleted the add_show_push_predicate branch January 20, 2022 13:27
zhouqiang-cl pushed a commit that referenced this pull request Feb 15, 2022
@ti-srebot
*: add pushdown for ShowStmt and implement for show columns (#31742) (#…
d60865a 
…31866)

* cherry pick #31742 to release-5.4

Signed-off-by: ti-srebot <[email protected]>
@hawkingrei
Copy link
Member Author

/cherry-pick release-5.4

1 similar comment
@hawkingrei
Copy link
Member Author

/cherry-pick release-5.4

@hawkingrei hawkingrei added needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. and removed needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Mar 23, 2022
@pingcap pingcap deleted a comment from ti-srebot Mar 23, 2022
@hawkingrei
Copy link
Member Author

/cherry-pick release-5.4

1 similar comment
@hawkingrei
Copy link
Member Author

/cherry-pick release-5.4

hawkingrei added a commit to hawkingrei/tidb that referenced this pull request Mar 23, 2022
@hawkingrei
*: add pushdown for ShowStmt and implement for show columns (pingcap#…
c289087 
…31742)

close pingcap#29910
@hawkingrei hawkingrei mentioned this pull request Mar 23, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this pull request Mar 23, 2022
@hawkingrei
*: add pushdown for ShowStmt and implement for show columns (#31742) (#…
8effbbc 
…33342)

close #29910
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiongjiwei xiongjiwei xiongjiwei left review comments

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@djshow832 djshow832 djshow832 approved these changes

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

show full columns like should be case insensitive
7 participants
@hawkingrei @ti-chi-bot @sre-bot @xhebox @wjhuang2016 @xiongjiwei @djshow832