Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: add retry and early terminate checking empty table #31798

Merged
merged 24 commits into from
Mar 16, 2022
Merged

lightning: add retry and early terminate checking empty table #31798

merged 24 commits into from
Mar 16, 2022

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Jan 19, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #31797

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Add retry to avoid precheck failure when query execution timeout

@glorv glorv added component/lightning This issue is related to Lightning of TiDB. needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Jan 19, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gozssky
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 19, 2022
@glorv glorv changed the title lightning: add retry and cancal for retry check table empty lightning: add retry and early terminate checking empty table Jan 19, 2022
@glorv
Copy link
Contributor Author

glorv commented Jan 19, 2022

/run-integration-br-test

sleepymole
sleepymole reviewed Jan 19, 2022
View reviewed changes
br/pkg/lightning/restore/check_info.go Outdated
var mockErr error
failpoint.Inject("CheckTableEmptyFailed", func() {
mockErr = errors.New("mock error")
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding this failpoint inside tableContainsData?

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 19, 2022
@glorv
Copy link
Contributor Author

glorv commented Jan 20, 2022

/run-integration-br-test

@sre-bot
Copy link
Contributor

sre-bot commented Jan 20, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/f34c3f3b9040b31a720d86d09a1c80160757acba

@glorv
Copy link
Contributor Author

glorv commented Jan 20, 2022

/run-check_dev

1 similar comment
@glorv
Copy link
Contributor Author

glorv commented Jan 20, 2022

/run-check_dev

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2022
@glorv glorv removed the needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 label Feb 15, 2022
glorv added a commit to ti-srebot/tidb that referenced this pull request Feb 21, 2022
@glorv
cherrypick pingcap#31798
6b9679f
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2022
@glorv
Copy link
Contributor Author

glorv commented Mar 16, 2022

/run-unit-test

lichunzhu
lichunzhu approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 16, 2022
@glorv
Copy link
Contributor Author

glorv commented Mar 16, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a667fcc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 16, 2022
@ti-chi-bot ti-chi-bot merged commit a702ef1 into pingcap:master Mar 16, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 16, 2022
@glorv @ti-srebot
cherry pick pingcap#31798 to release-5.4
b4dbe9c 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 16, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33148

@glorv glorv deleted the retry-check-empty branch March 16, 2022 09:23
ti-chi-bot pushed a commit that referenced this pull request Apr 21, 2022
@ti-srebot
lightning: add retry and early terminate checking empty table (#31798) (
c9b917b 
#33148)

close #31797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@lichunzhu lichunzhu lichunzhu approved these changes

@sleepymole sleepymole sleepymole approved these changes

Assignees
No one assigned
Labels
component/lightning This issue is related to Lightning of TiDB. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lightning get stuck when check table empty failed
7 participants
@glorv @ti-chi-bot @sre-bot @ti-srebot @kennytm @sleepymole @lichunzhu