Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: support trace candidates for Datasource #31810

Merged
merged 12 commits into from
Jan 21, 2022
Merged

planner: support trace candidates for Datasource #31810

merged 12 commits into from
Jan 21, 2022

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Jan 19, 2022

What problem does this PR solve?

Issue Number: ref #29661

What is changed and how it works?

Support trace candidates for Datasource and revise some code sturcture.

Check List

Tests

  • Unit test

Release note

None

@Yisaer
revise plan trace
83f1087 
Signed-off-by: yisaer <[email protected]>

revise plan trace

Signed-off-by: yisaer <[email protected]>

revise plan trace

Signed-off-by: yisaer <[email protected]>

revise plan trace

Signed-off-by: yisaer <[email protected]>

revise plan trace

Signed-off-by: yisaer <[email protected]>
@Yisaer
fix lint
290b428 
Signed-off-by: yisaer <[email protected]>
@Yisaer
support datasource
9a4bad1 
Signed-off-by: yisaer <[email protected]>
@Yisaer
revise
7cb8f21 
Signed-off-by: yisaer <[email protected]>
@Yisaer
solve conflict
f1e6abf 
Signed-off-by: yisaer <[email protected]>
@Yisaer
add testcase
ba90ccd 
Signed-off-by: yisaer <[email protected]>

fix candidates

Signed-off-by: yisaer <[email protected]>

fix candidates

Signed-off-by: yisaer <[email protected]>

add final plan

Signed-off-by: yisaer <[email protected]>

add final plan

Signed-off-by: yisaer <[email protected]>
@Yisaer Yisaer added the sig/planner SIG: Planner label Jan 19, 2022
@Yisaer Yisaer requested a review from rebelice January 19, 2022 08:49
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 19, 2022
@Yisaer Yisaer requested a review from JmPotato January 19, 2022 08:50
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 20, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 20, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Jan 20, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 479f3e7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 20, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Jan 20, 2022

/run-unit-test

1 similar comment
@Yisaer
Copy link
Contributor Author

Yisaer commented Jan 20, 2022

/run-unit-test

@ti-chi-bot
Copy link
Member

@Yisaer: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Contributor

sre-bot commented Jan 20, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b1f0283a35667a142f702bf2f98f6dd05d6a970c

@Yisaer
Copy link
Contributor Author

Yisaer commented Jan 21, 2022

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 2d62d23 into pingcap:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelice rebelice rebelice approved these changes

@JmPotato JmPotato JmPotato approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yisaer @ti-chi-bot @sre-bot @JmPotato @rebelice