Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix weak consistency not work #31935

Merged
merged 5 commits into from
Jan 25, 2022
Merged

*: fix weak consistency not work #31935

merged 5 commits into from
Jan 25, 2022

Conversation

you06
Copy link
Contributor

@you06 you06 commented Jan 24, 2022

Signed-off-by: you06 [email protected]

What problem does this PR solve?

Issue Number: close #31933

Problem Summary:

What is changed and how it works?

#30943 allows TiDB read by TiKV's RC but with a wrong implementation. This PR merges the RC usage into SetFromSessionVars and fix the issue that the weak-consistency read does not work.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the issue that the weak-consistency read does not work.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • youjiali1995

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 24, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 24, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jan 24, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/e16711479f5bbd08fc2cc3f217a2e2d068d71b4a

cfzjywxk
cfzjywxk approved these changes Jan 25, 2022
View reviewed changes
sessionctx/stmtctx/stmtctx_test.go
tk := testkit.NewTestKit(t, store)
tk.MustExec("use test")
tk.MustExec("drop table if exists t")
tk.MustExec("create table t(id int primary key, c int, c1 int, unique index i(c))")

execAndCheck := func(sql string, rows [][]interface{}, isolationLevel kv.IsoLevel) {
Copy link
Contributor

@cfzjywxk cfzjywxk Jan 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this check hook function be executed for each kv request?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hook function will be executed in distsql only.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 25, 2022
@cfzjywxk cfzjywxk added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Jan 25, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 25, 2022
@ti-chi-bot
Copy link
Member

@zyguan: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f8d86fa

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 25, 2022
@you06
Copy link
Contributor Author

you06 commented Jan 25, 2022

/run-check_dev_2

@you06
Copy link
Contributor Author

you06 commented Jan 25, 2022

/run-check_dev_2

@cfzjywxk
Copy link
Contributor

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 9e928b2 into pingcap:master Jan 25, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 25, 2022
@you06 @ti-srebot
cherry pick pingcap#31935 to release-5.4
a12ad22 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jan 25, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #31949

@you06 you06 deleted the fix-weak-consistency-not-work branch January 25, 2022 06:29
ti-chi-bot pushed a commit that referenced this pull request Jan 25, 2022
@ti-srebot
*: fix weak consistency not work (#31935) (#31949)
55f3b24 
close #31933
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youjiali1995 youjiali1995 youjiali1995 approved these changes

@zyguan zyguan zyguan approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@TonsnakeLin TonsnakeLin Awaiting requested review from TonsnakeLin

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weak read consistency cannot take effect
7 participants
@you06 @ti-chi-bot @sre-bot @cfzjywxk @ti-srebot @zyguan @youjiali1995