ddl: Add warning for resetting specified AUTO_INCREMENT value

[dveeden]

What problem does this PR solve?

Issue Number: ref #32043

Problem Summary: Resetting an AUTO_INCREMENT value of a table works differently than in MySQL. Currently it is difficult to find the right way of doing this.

This adds a warning if we can't set the AUTO_INCREMENT to the value specified by the user.

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• mjonss
• morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[dveeden]

/cc @mjonss @bb7133

[dveeden]

/cc @morgo

[mjonss]

LGTM,

But please add a test like:

diff --git a/ddl/db_integration_test.go b/ddl/db_integration_test.go
index cff9301f1e..4e2e2bcf56 100644
--- a/ddl/db_integration_test.go
+++ b/ddl/db_integration_test.go
@@ -2760,6 +2760,22 @@ func (s *testIntegrationSuite3) TestAutoIncrementForce(c *C) {
        tk.MustQuery("select * from t;").Check(testkit.Rows("101", "112", "500"))
        tk.MustQuery("select * from t order by a;").Check(testkit.Rows("101", "112", "500"))
        tk.MustExec("drop table if exists t;")
+
+       tk.MustExec("create table t(a int primary key auto_increment)")
+       tk.MustExec("insert into t values (200)")
+       tk.MustQuery("show create table t").Check(testkit.Rows(
+               "t CREATE TABLE `t` (\n" +
+                       "  `a` int(11) NOT NULL AUTO_INCREMENT,\n" +
+                       "  PRIMARY KEY (`a`) /*T![clustered_index] CLUSTERED */\n" +
+                       ") ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin AUTO_INCREMENT=5201"))
+       tk.MustExec("alter table t auto_increment=100;")
+       tk.MustQuery("show warnings").Check(testkit.Rows("Warning 1105 Can't reset AUTO_INCREMENT to 100 without FORCE option, using 5201 instead"))
+       tk.MustQuery("show create table t").Check(testkit.Rows(
+               "t CREATE TABLE `t` (\n" +
+                       "  `a` int(11) NOT NULL AUTO_INCREMENT,\n" +
+                       "  PRIMARY KEY (`a`) /*T![clustered_index] CLUSTERED */\n" +
+                       ") ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin AUTO_INCREMENT=5201"))
+       tk.MustExec("drop table t")
 }
 
 func (s *testIntegrationSuite3) TestIssue20490(c *C) {

[bb7133]

LGTM

[bb7133]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 6929ed8

[ti-chi-bot]

@dveeden: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[sre-bot]

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/5843b5fae295ec9506b3aac95997230bbaf72ef3