-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: track cluster-level analyze jobs and make it persistent #32215
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/694be1edc582947e5bd0ea714da0bda84bc8b3e1 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 70f195f
|
/run-unit-test |
@xuyifangreeneyes: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #32403
Problem Summary:
show analyze status
only shows analyze jobs on self instance and the previous analyze jobs are cleared after rebooting.What is changed and how it works?
Previously analyze jobs are tracked in memory. In the PR we introduce a system table
mysql.analyze_jobs
and track analyze jobs in the system table. The implementation ofshow analyze status
is changed to read recent 30 analyze jobs frommysql.analyze_jobs
. In this way the analyze jobs are persistent even after rebooting TiDB. Besides, each TiDB server dumps analyze jobs into the same table soshow analyze status
shows cluster-level analyze jobs. We also introduce two more fieldsinstance
andprocess_id
to indicate on which TiDB and which process the analyze job is executed.Check List
Tests
Side effects
Documentation
Release note