-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: lower-case-table-names should be removed from tidb-config #32886
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/4f2bd4c2173fec63bfe9611b508163db48169450 |
@@ -285,9 +285,9 @@ func (b *executorBuilder) buildBRIE(s *ast.BRIEStmt, schema *expression.Schema) | |||
cfg.TableFilter = filter.All() | |||
} | |||
|
|||
if tidbCfg.LowerCaseTableNames != 0 { | |||
cfg.TableFilter = filter.CaseInsensitive(cfg.TableFilter) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is fine because I'm not familiar with BR(IMHO it's OK since BR in SQL is barely used for now?)
PTAL @3pointer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it is used to specify if the tablefilter should act case insensitive. I just changed it to always be case insensitive, which looks like the correct behavior anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think it's okay to always be case insensitive. since we only support case insensitive in tidb.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ae3abd0
|
/run-unit-test |
/run-all-tests |
1 similar comment
/run-all-tests |
@morgo: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-unit-test |
What problem does this PR solve?
Issue Number: close #32885
Problem Summary:
lower-case-tables-names should not be in configuration.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note