Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: lower-case-table-names should be removed from tidb-config #32886

Merged
merged 5 commits into from
Mar 18, 2022
Merged

*: lower-case-table-names should be removed from tidb-config #32886

merged 5 commits into from
Mar 18, 2022

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Mar 7, 2022

What problem does this PR solve?

Issue Number: close #32885

Problem Summary:

lower-case-tables-names should not be in configuration.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

The configuration option `lower-case-table-names` has no effect in TiDB. It has been removed from configuration.

@morgo morgo requested a review from a team as a code owner March 7, 2022 16:52
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 7, 2022
@morgo morgo changed the title *: lower-case-table-names is a noop *: lower-case-table-names should be removed from tidb-config Mar 7, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 7, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/4f2bd4c2173fec63bfe9611b508163db48169450

@morgo morgo requested a review from bb7133 March 9, 2022 02:40
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 10, 2022
@xiongjiwei xiongjiwei added the compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. label Mar 10, 2022
bb7133
bb7133 reviewed Mar 10, 2022
View reviewed changes
executor/brie.go
@@ -285,9 +285,9 @@ func (b *executorBuilder) buildBRIE(s *ast.BRIEStmt, schema *expression.Schema)
cfg.TableFilter = filter.All()
}

if tidbCfg.LowerCaseTableNames != 0 {
cfg.TableFilter = filter.CaseInsensitive(cfg.TableFilter)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is fine because I'm not familiar with BR(IMHO it's OK since BR in SQL is barely used for now?)

PTAL @3pointer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it is used to specify if the tablefilter should act case insensitive. I just changed it to always be case insensitive, which looks like the correct behavior anyway.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think it's okay to always be case insensitive. since we only support case insensitive in tidb.

@morgo morgo requested a review from bb7133 March 16, 2022 02:23
bb7133
bb7133 approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 17, 2022
@morgo
Copy link
Contributor Author

morgo commented Mar 17, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ae3abd0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2022
@morgo
Copy link
Contributor Author

morgo commented Mar 17, 2022

/run-unit-test

@morgo
Copy link
Contributor Author

morgo commented Mar 18, 2022

/run-all-tests

1 similar comment
@hawkingrei
Copy link
Member

/run-all-tests

@ti-chi-bot
Copy link
Member

@morgo: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 7291238 into pingcap:master Mar 18, 2022
@morgo morgo deleted the lower-case-table-names branch May 26, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@bb7133 bb7133 bb7133 approved these changes

@3pointer 3pointer Awaiting requested review from 3pointer

Assignees
No one assigned
Labels
compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't pretend lower_case_table_names is changable
7 participants
@morgo @ti-chi-bot @sre-bot @hawkingrei @bb7133 @3pointer @xiongjiwei