-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser/mysql, privilege/privileges: fix trigger privilege #32893
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b4c7e88
to
0dec6b8
Compare
/run-unit-test |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/36373ee7b66ebe7c54eee6c260d3b5d63a8f80c2 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: f7ca7f7
|
/run-unit-test |
1 similar comment
/run-unit-test |
What problem does this PR solve?
Issue Number: close #32891
Problem Summary:
A grant statement was failing because of the TRIGGER privilege, which in MySQL can be specified on a DB and Table level. This addresses the reported issue, but a second issue where a nil pointer dereference was found did not seem to be reproducible against master. It might have just been my feature branch that failed, but I've added the case to the tests in case my feature branch merges and we miss it.
What is changed and how it works?
The trigger privilege is now specifyable on a DB or Table level. This has no effect in TiDB as triggers are not supported, but it improves MySQL compatibility.
Check List
Tests
Side effects
Documentation
Release note