Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser/mysql, privilege/privileges: fix trigger privilege #32893

Merged
merged 16 commits into from
Mar 23, 2022

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Mar 8, 2022

What problem does this PR solve?

Issue Number: close #32891

Problem Summary:

A grant statement was failing because of the TRIGGER privilege, which in MySQL can be specified on a DB and Table level. This addresses the reported issue, but a second issue where a nil pointer dereference was found did not seem to be reproducible against master. It might have just been my feature branch that failed, but I've added the case to the tests in case my feature branch merges and we miss it.

What is changed and how it works?

The trigger privilege is now specifyable on a DB or Table level. This has no effect in TiDB as triggers are not supported, but it improves MySQL compatibility.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

The trigger privilege is now specifyable on a DB or Table level. This has no effect in TiDB as triggers are not supported, but it improves MySQL compatibility.

@morgo morgo requested review from tiancaiamao and mjonss March 8, 2022 04:01
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 8, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • mjonss
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 8, 2022
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 8, 2022
@morgo
Copy link
Contributor Author

morgo commented Mar 10, 2022

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Mar 14, 2022

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 22, 2022
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f7ca7f7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 22, 2022
@morgo
Copy link
Contributor Author

morgo commented Mar 22, 2022

/run-unit-test

1 similar comment
@morgo
Copy link
Contributor Author

morgo commented Mar 22, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 3ddd959 into pingcap:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect usage of DB GRANT and NON-DB PRIVILEGES
6 participants