-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Add support for execute prepared statement to staleread.Processor
#32941
*: Add support for execute prepared statement to staleread.Processor
#32941
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/d3e0e8a1076cf45ae4d3153c83a58a83d51df8a6 |
/run-mysql-test |
/run-check-issue-triage-complete |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 725b319
|
@lcwangchao: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #32938
What is changed and how it works?
This is one of the PRs to refactor stale read. The full draft is here: #32325
In the previous implement we parse the execute statement's stale read context in planner phase. This introduces some special codes for execute, for example, we need to reset executorBuilder's context when building Execute instead of when constructing executorBuilder.
This implement removed the above codes and parse the execute's stale read context at the beginning the statement. It is the same logical with select statement, so the processor codes can be reused easily.
This PR also added some unit tests and asserts to check the behavior is the same with the previous implement.
Check List
Tests
Side effects
Documentation
Release note