Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gomod: update dependency for golang1.18 #33053

Merged
merged 6 commits into from
Mar 17, 2022
Merged

gomod: update dependency for golang1.18 #33053

merged 6 commits into from
Mar 17, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Mar 14, 2022 •
edited
Loading

Signed-off-by: Weizhen Wang [email protected]

What problem does this PR solve?

Issue Number: ref #32874

Problem Summary:

asm: xxhash_amd64.s:120: when dynamic linking, R15 is clobbered by a global variable access and is used here: 00092 (/go/pkg/mod/github.com/cespare/[email protected]/xxhash_amd64.s:120)	ADDQ	R15, AX

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Mar 14, 2022
@hawkingrei
Copy link
Member Author

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Mar 14, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/d947a713de6c881c73c6df9c64bb52751f9e5dc4

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2022
jackysp
jackysp reviewed Mar 15, 2022
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the title.

@hawkingrei hawkingrei added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2022
@hawkingrei hawkingrei changed the title go.mod: update freecach for golang1.18 go.mod: update dependency for golang1.18 Mar 16, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 16, 2022
@purelind
Copy link
Contributor

/rebuild

@hawkingrei hawkingrei changed the title go.mod: update dependency for golang1.18 gomod: update dependency for golang1.18 Mar 16, 2022
@hawkingrei
Copy link
Member Author

/run-check_dev_2
/run-unit-test

@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei
Copy link
Member Author

/run-all-tests

@purelind
Copy link
Contributor

/run-mysql-test

@purelind
Copy link
Contributor

/run-all-tests

@purelind
Copy link
Contributor

/run-all-tests

1 similar comment
@purelind
Copy link
Contributor

/run-all-tests

@purelind
Copy link
Contributor

/run-unit-test

@purelind
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 17, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 17, 2022
@hawkingrei
go.mod: update golang1.18
291d53c 
Signed-off-by: Weizhen Wang <[email protected]>
@purelind
Copy link
Contributor

/run-mysql-test

@purelind purelind mentioned this pull request Mar 17, 2022
Merged
@dianqihanwangzi
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@dianqihanwangzi: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member Author

/run-unit-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 17, 2022
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 88ca7a2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2022
@purelind
Copy link
Contributor

/run-unit-test

@purelind
Copy link
Contributor

/run-mysql-test

@hawkingrei
Copy link
Member Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 6b2e37f into pingcap:master Mar 17, 2022
@hawkingrei hawkingrei deleted the for_golang118 branch March 17, 2022 07:46
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@lcwangchao lcwangchao lcwangchao approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@hawkingrei @ti-chi-bot @sre-bot @purelind @dianqihanwangzi @ti-srebot @lcwangchao @tiancaiamao @jackysp @XuHuaiyu