Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: Disable prepared plan cache for partitioned tables in dynamic prune mode #33098

Merged
merged 5 commits into from
Mar 19, 2022
Merged

planner: Disable prepared plan cache for partitioned tables in dynamic prune mode #33098

merged 5 commits into from
Mar 19, 2022

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Mar 15, 2022

Also removed an unused parameter for less confusing api

What problem does this PR solve?

Issue Number: ref #33031

Problem Summary:
There are some issues with partitioned tables and the prepare plan cache, while the issues is being investigated and fixed, we disable the cache to serve correct results.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Disable prepared plan cache for partitioned tables (was previously only enabled under dynamic prune mode)

@mjonss
Disable prepared plan cache for partitioned tables in dynamic prune mode
1fb5062 
Also removed an unused parameter for less confusing api
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 15, 2022
@mjonss mjonss requested a review from qw4990 March 15, 2022 13:29
@mjonss
Copy link
Contributor Author

mjonss commented Mar 15, 2022

/cc @tiancaiamao

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 17, 2022
bb7133
bb7133 approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 18, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 18, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/c24505340e781132000f7671ce149899475825f7

@hawkingrei
Copy link
Member

/run-mysql-test

@bb7133
Copy link
Member

bb7133 commented Mar 19, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a5580e2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 19, 2022
@ti-chi-bot ti-chi-bot merged commit c7a3f31 into pingcap:master Mar 19, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 19, 2022
@mjonss @ti-srebot
cherry pick pingcap#33098 to release-6.0
404a3e8 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 19, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33259

@mjonss mjonss deleted the disable-plan-cache-for-dyn-prune branch March 21, 2022 07:30
@morgo morgo mentioned this pull request Mar 21, 2022
Closed
mjonss added a commit to mjonss/tidb that referenced this pull request Mar 21, 2022
@mjonss
Updated failing test after pingcap#33098
259f701
@mjonss mjonss mentioned this pull request Mar 21, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this pull request Mar 22, 2022
@mjonss
planner: Updated failing test after #33098 (#33299)
b7a2d62 
close #33297
@ti-srebot ti-srebot mentioned this pull request Mar 24, 2022
Closed
12 tasks
@mjonss mjonss mentioned this pull request Aug 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@qw4990 qw4990 qw4990 approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mjonss @ti-chi-bot @sre-bot @hawkingrei @bb7133 @ti-srebot @qw4990