Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: support pushdown dayofweek and dayofyear to tiflash #33131

Merged
merged 8 commits into from
Mar 16, 2022
Merged

expression: support pushdown dayofweek and dayofyear to tiflash #33131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9f32cb3
support dayofweek and dayofyear pushdown
gengliqi Mar 16, 2022
4fd5528
fix TestExprOnlyPushDownToTiKV
gengliqi Mar 16, 2022
e4a99b3
Merge branch 'master' into dayofweek_year
gengliqi Mar 16, 2022
64b8953
Merge branch 'master' into dayofweek_year
gengliqi Mar 16, 2022
9b957bf
Merge branch 'master' into dayofweek_year
ti-chi-bot Mar 16, 2022
10552da
Merge branch 'master' into dayofweek_year
ti-chi-bot Mar 16, 2022
379f9a6
Merge branch 'master' into dayofweek_year
ti-chi-bot Mar 16, 2022
5ef7486
Merge branch 'master' into dayofweek_year
ti-chi-bot Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion expression/expr_to_pb_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1083,11 +1083,21 @@ func TestExprPushDownToFlash(t *testing.T) {
require.NoError(t, err)
exprs = append(exprs, function)

// DayOfWeek
function, err = NewFunction(mock.NewContext(), ast.DayOfWeek, types.NewFieldType(mysql.TypeDatetime), datetimeColumn)
require.NoError(t, err)
exprs = append(exprs, function)

// DayOfMonth
function, err = NewFunction(mock.NewContext(), ast.DayOfMonth, types.NewFieldType(mysql.TypeDatetime), datetimeColumn)
require.NoError(t, err)
exprs = append(exprs, function)

// DayOfYear
function, err = NewFunction(mock.NewContext(), ast.DayOfYear, types.NewFieldType(mysql.TypeDatetime), datetimeColumn)
require.NoError(t, err)
exprs = append(exprs, function)

// LastDay
function, err = NewFunction(mock.NewContext(), ast.LastDay, types.NewFieldType(mysql.TypeDatetime), datetimeColumn)
require.NoError(t, err)
Expand Down Expand Up @@ -1478,7 +1488,7 @@ func TestExprOnlyPushDownToTiKV(t *testing.T) {
sc := new(stmtctx.StatementContext)
client := new(mock.Client)

function, err := NewFunction(mock.NewContext(), "dayofyear", types.NewFieldType(mysql.TypeLonglong), genColumn(mysql.TypeDatetime, 1))
function, err := NewFunction(mock.NewContext(), "weekofyear", types.NewFieldType(mysql.TypeLonglong), genColumn(mysql.TypeDatetime, 1))
require.NoError(t, err)
var exprs = make([]Expression, 0)
exprs = append(exprs, function)
Expand Down
2 changes: 1 addition & 1 deletion expression/expression.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1056,7 +1056,7 @@ func scalarExprSupportedByFlash(function *ScalarFunction) bool {
ast.Concat, ast.ConcatWS,
ast.Date, ast.Year, ast.Month, ast.Day, ast.Quarter, ast.DayName, ast.MonthName,
ast.DateDiff, ast.TimestampDiff, ast.DateFormat, ast.FromUnixTime,
ast.DayOfMonth, ast.LastDay,
ast.DayOfWeek, ast.DayOfMonth, ast.DayOfYear, ast.LastDay,

ast.Sqrt, ast.Log, ast.Log2, ast.Log10, ast.Ln, ast.Exp, ast.Pow, ast.Sign,
ast.Radians, ast.Degrees, ast.Conv, ast.CRC32,
Expand Down