Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: Revert "server: Improve compatibility with MySQL 5.5 and 5.6 clients … #33142

Merged
merged 3 commits into from
Mar 16, 2022
Merged

server: Revert "server: Improve compatibility with MySQL 5.5 and 5.6 clients … #33142

merged 3 commits into from
Mar 16, 2022

Conversation

djshow832
Copy link
Contributor

…(#32338)"

This reverts commit 7e8ca4c.

What problem does this PR solve?

Issue Number: close #33141

Problem Summary:
Clients cannot connect to TiDB anymore.

What is changed and how it works?

Revert #32338 for now because it's safer.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 16, 2022
@bb7133 bb7133 mentioned this pull request Mar 16, 2022
Closed
bb7133
bb7133 approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 16, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 16, 2022
@tiancaiamao
Copy link
Contributor

Maybe we need to add more ORM or other connector tests for such scenario...

@bb7133
Copy link
Member

bb7133 commented Mar 16, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8573e0f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 16, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 16, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/e73aef6d2c4bbd368925a2dc3b26bbc3c255b5ca

@ti-chi-bot ti-chi-bot merged commit 44aae22 into pingcap:master Mar 16, 2022
@djshow832 djshow832 mentioned this pull request Mar 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@bb7133 bb7133 bb7133 approved these changes

@dveeden dveeden Awaiting requested review from dveeden

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clients with mysql_native_password cannot connect to TiDB
5 participants
@djshow832 @ti-chi-bot @tiancaiamao @bb7133 @sre-bot