-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
table/tables: fix some stability issues with cached table #33171
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ab8d40d
table/tables: fix some stability issues with cached table
tiancaiamao 8a0b2e5
address comment
tiancaiamao c858ed4
Merge branch 'master' into stability-test
ti-chi-bot d61d977
Merge branch 'master' into stability-test
tiancaiamao 0d3b26b
Merge branch 'master' into stability-test
tiancaiamao 5407252
Merge branch 'master' into stability-test
tiancaiamao 1264f19
Merge branch 'master' into stability-test
tiancaiamao ba88137
Merge branch 'master' into stability-test
tiancaiamao 5210eff
Merge branch 'master' into stability-test
ti-chi-bot dd917c9
Merge branch 'master' into stability-test
tiancaiamao 8ea8887
Merge branch 'master' into stability-test
tiancaiamao 72f881f
Merge branch 'master' into stability-test
tiancaiamao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -211,15 +211,20 @@ func waitForLeaseExpire(oldReadLease, now uint64) time.Duration { | |
if oldReadLease >= now { | ||
t1 := oracle.GetTimeFromTS(oldReadLease) | ||
t2 := oracle.GetTimeFromTS(now) | ||
waitDuration := t1.Sub(t2) | ||
return waitDuration | ||
if t1.After(t2) { | ||
waitDuration := t1.Sub(t2) | ||
return waitDuration | ||
} | ||
return time.Microsecond | ||
} | ||
return 0 | ||
} | ||
|
||
// RenewReadLease renew the read lock lease. | ||
// Return the current lease value on success, and return 0 on fail. | ||
func (h *stateRemoteHandle) RenewReadLease(ctx context.Context, tid int64, oldLocalLease, newValue uint64) (uint64, error) { | ||
h.Lock() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The most important change to fix the panic issue. |
||
defer h.Unlock() | ||
var newLease uint64 | ||
err := h.runInTxn(ctx, func(ctx context.Context, now uint64) error { | ||
lockType, remoteLease, _, err := h.loadRow(ctx, tid) | ||
|
@@ -266,6 +271,8 @@ func (h *stateRemoteHandle) RenewReadLease(ctx context.Context, tid int64, oldLo | |
} | ||
|
||
func (h *stateRemoteHandle) RenewWriteLease(ctx context.Context, tid int64, newLease uint64) (bool, error) { | ||
h.Lock() | ||
defer h.Unlock() | ||
var succ bool | ||
err := h.runInTxn(ctx, func(ctx context.Context, now uint64) error { | ||
lockType, oldLease, _, err := h.loadRow(ctx, tid) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is to make the code more robust, handle
waitDuration < 0