*: revert #27021 to fix a bug that selection can not be pushed down when having clause above aggregation (#33168) #33177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #33168 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/33177
After apply modifications, you can push your change to this PR via:
Signed-off-by: wjhuang2016 [email protected]
What problem does this PR solve?
Issue Number: close #33166
Problem Summary:
I don't know why #27021 get merged, but it's totally wrong.
First, selection can be pushed down when having clause above aggregation, it's true.
Second, the root cause of #26496 is the same as #30094, which is fixed by #30120
What is changed and how it works?
Revert #27021
Check List
Tests
Side effects
Documentation
Release note