Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: add collations from MySQL 8.0 #33212

Merged
merged 5 commits into from
Mar 18, 2022
Merged

parser: add collations from MySQL 8.0 #33212

merged 5 commits into from
Mar 18, 2022

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Mar 17, 2022 •
edited
Loading

Signed-off-by: lance6716 [email protected]

What problem does this PR solve?

Issue Number: ref #7968

Problem Summary:

DM failed to parse CREATE TABLE when upstream is MySQL 8.0, like https://asktug.com/t/topic/573639

What is changed and how it works?

add parser support for collations in MySQL 8.0.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Enhance compatibility of parsing collations of MySQL 8.0

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 17, 2022
@lance6716
fix CI
99463e0 
Signed-off-by: lance6716 <[email protected]>
@Defined2014
Copy link
Contributor

/run-mysql-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 17, 2022
wjhuang2016
wjhuang2016 reviewed Mar 17, 2022
View reviewed changes
parser/parser_test.go Outdated
@@ -21,6 +21,8 @@ import (
"testing"

"github.com/pingcap/errors"
"github.com/stretchr/testify/require"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

。。。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the rule of separating 3-rd party imports? parser/charset/charset.go did so but this file didn't

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't care about it.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 18, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e68b419

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 18, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 18, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/27d18f29f627cda5b93fda20ebdb43ca16ffd2e6

@ti-chi-bot ti-chi-bot merged commit a304490 into pingcap:master Mar 18, 2022
@lance6716 lance6716 mentioned this pull request Mar 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcwangchao lcwangchao lcwangchao approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lance6716 @ti-chi-bot @Defined2014 @sre-bot @lcwangchao @wjhuang2016 @xiongjiwei