Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: Fix constant zero/one/null flen with -1 issue #33221

Merged
merged 2 commits into from
Mar 21, 2022
Merged

expression: Fix constant zero/one/null flen with -1 issue #33221

merged 2 commits into from
Mar 21, 2022

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented Mar 18, 2022

What problem does this PR solve?

Issue Number: close #33220

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 18, 2022
@yibin87
Copy link
Contributor Author

yibin87 commented Mar 18, 2022

/cc @windtalker @XuHuaiyu

@sre-bot
Copy link
Contributor

sre-bot commented Mar 18, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/0260986b4275fd329899cf4d1892eb6262aae3f5

windtalker
windtalker approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 18, 2022
@yibin87
Copy link
Contributor Author

yibin87 commented Mar 18, 2022

/check-issue-triage-complete

@yibin87
Copy link
Contributor Author

yibin87 commented Mar 18, 2022

/run-check-issue-triage-complete

@yibin87
Copy link
Contributor Author

yibin87 commented Mar 18, 2022

/cc review @fuzhe1989

@ti-chi-bot
Copy link
Member

@yibin87: GitHub didn't allow me to request PR reviews from the following users: review.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc review @fuzhe1989

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

XuHuaiyu
XuHuaiyu approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 21, 2022
@XuHuaiyu XuHuaiyu changed the title [expression]: Fix constant zero/one/null flen with -1 issue expression: Fix constant zero/one/null flen with -1 issue Mar 21, 2022
@XuHuaiyu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9959e3f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 21, 2022
@yibin87
Copy link
Contributor Author

yibin87 commented Mar 21, 2022

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 50954e8 into pingcap:master Mar 21, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 21, 2022
@yibin87 @ti-srebot
cherry pick pingcap#33221 to release-6.0
d4f6143 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 21, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@windtalker windtalker windtalker approved these changes

@fuzhe1989 fuzhe1989 Awaiting requested review from fuzhe1989

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Constant folding zero/one/null with default flen -1
6 participants
@yibin87 @ti-chi-bot @sre-bot @XuHuaiyu @ti-srebot @windtalker