-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: Fix constant zero/one/null flen with -1 issue #33221
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/cc @windtalker @XuHuaiyu |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/0260986b4275fd329899cf4d1892eb6262aae3f5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/check-issue-triage-complete |
/run-check-issue-triage-complete |
/cc review @fuzhe1989 |
@yibin87: GitHub didn't allow me to request PR reviews from the following users: review. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 9959e3f
|
/run-mysql-test |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-6.0 in PR #33286 |
What problem does this PR solve?
Issue Number: close #33220
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note