Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: reset all state when table reader executor close (#33219) #33225

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 18, 2022

cherry-pick #33219 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/33225

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/33225:release-5.3-64b057dea2e9

What problem does this PR solve?

Issue Number: close #33214

Problem Summary:

What is changed and how it works?

When there is a Apply executor, it may Open/Close its children executor several times.

mysql> explain select col from t t1 where (select count(*) from t t2 where t2.col = t1.col or t2.col =  'sdf') > 1;
+------------------------------------+---------+-----------+---------------+-------------------------------------------------------+
| id                                 | estRows | task      | access object | operator info                                         |
+------------------------------------+---------+-----------+---------------+-------------------------------------------------------+
| Projection_13                      | 5.00    | root      |               | test.t.col                                            |
| └─Apply_15                         | 5.00    | root      |               | CARTESIAN inner join                                  |
|   ├─UnionScan_16(Build)            | 5.00    | root      |               |                                                       |
|   │ └─TableReader_18               | 5.00    | root      |               | data:TableFullScan_17                                 |
|   │   └─TableFullScan_17           | 5.00    | cop[tikv] | table:t1      | keep order:false, stats:pseudo                        |
|   └─Selection_19(Probe)            | 0.80    | root      |               | gt(Column#5, 1)                                       |
|     └─StreamAgg_21                 | 1.00    | root      |               | funcs:count(1)->Column#5                              |
|       └─UnionScan_22               | 0.01    | root      |               | or(eq(test.t.col, test.t.col), eq(test.t.col, "sdf")) |
|         └─TableReader_25           | 0.01    | root      |               | data:Selection_24                                     |
|           └─Selection_24           | 0.01    | cop[tikv] |               | or(eq(test.t.col, test.t.col), eq(test.t.col, "sdf")) |
|             └─TableFullScan_23     | 5.00    | cop[tikv] | table:t2      | keep order:false, stats:pseudo                        |
+------------------------------------+---------+-----------+---------------+-------------------------------------------------------+
11 rows in set (0.00 sec)

So it's important that after Open/Close, the executor can be reused.
However, the table reader doen't reset its keyRange and when UnionScan Open/Close it will get repeated keyRange.
And finally return wrong result to its parent executor.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 18, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 18, 2022
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 18, 2022
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.3-cherry-pick labels Mar 18, 2022
@ti-srebot ti-srebot added this to the v5.3.1 milestone Mar 18, 2022
@ti-chi-bot ti-chi-bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 18, 2022
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 18, 2022
@ti-srebot
Copy link
Contributor Author

@tiancaiamao you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 14, 2022
@tiancaiamao
Copy link
Contributor

PTAL @lcwangchao @XuHuaiyu

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 16, 2022
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Jun 20, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 23, 2022
@lcwangchao
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 75a3f03

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 23, 2022
@tiancaiamao
Copy link
Contributor

/run-unit-test

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2023
@ti-chi-bot ti-chi-bot closed this Dec 1, 2023
@ti-chi-bot
Copy link
Member

This pull request is closed because its related version has closed automatic cherry-picking.
If it's still needed, you can reopen it or just regenerate it using bot,
see:

https://prow.tidb.net/command-help#cherrypick
https://book.prow.tidb.net/#/plugins/cherrypicker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.3-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants