-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: reset all state when table reader executor close (#33219) #33227
executor: reset all state when table reader executor close (#33219) #33227
Conversation
Signed-off-by: ti-srebot <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@tiancaiamao you're already a collaborator in bot's repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tiancaiamao please resolve conflicts
Done @ichn-hu |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: bf320e4
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/bc3d845dfe61356101b35179b53def7520db3296 |
/merge |
cherry-pick #33219 to release-5.4
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/33227
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #33214
Problem Summary:
What is changed and how it works?
When there is a
Apply
executor, it may Open/Close its children executor several times.So it's important that after Open/Close, the executor can be reused.
However, the table reader doen't reset its
keyRange
and when UnionScan Open/Close it will get repeated keyRange.And finally return wrong result to its parent executor.
Check List
Tests
Side effects
Documentation
Release note