Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain, session: clean up in BootstrapSession #33234

Merged
merged 3 commits into from
Mar 21, 2022
Merged

domain, session: clean up in BootstrapSession #33234

merged 3 commits into from
Mar 21, 2022

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Mar 18, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #33235

Problem Summary:

What is changed and how it works?

  • Using createSessions instead of a lot of createSession.
  • Extract the ability to update memory-related configurations and system variables into a function.
  • Do tiny cleanup.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@zimulala zimulala added the sig/sql-infra SIG: SQL Infra label Mar 18, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Mar 18, 2022
AilinKid
AilinKid approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 18, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 18, 2022
@xhebox
Copy link
Contributor

xhebox commented Mar 18, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d08210a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 18, 2022
@ti-chi-bot
Copy link
Member

@zimulala: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member

/run-check-dev
/run-unit-test
/run-mysql-test

@hawkingrei
Copy link
Member

/run-check_dev

@sre-bot
Copy link
Contributor

sre-bot commented Mar 18, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9f3cf975c05bd415cca15be9a2d7e5412665916a

@hawkingrei
Copy link
Member

/run-check_dev

@hawkingrei
Copy link
Member

@zimulala Please fix the linter.


[2022-03-18T13:56:30.043Z]   ✘  https://revive.run/r#exported[](https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_check/detail/tidb_ghpr_check/55714/pipeline#step-98-log-110)  exported method Domain.LoadStatsLoop should have comment or be unexported  

[2022-03-18T13:56:30.043Z]   domain/domain.go:1278:1

@hawkingrei
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 21, 2022
@zimulala
Copy link
Contributor Author

PTAL @hawkingrei

@hawkingrei
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2022
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9f3cf97

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 21, 2022
@ti-chi-bot ti-chi-bot merged commit cd9c04a into pingcap:master Mar 21, 2022
@zimulala zimulala deleted the zimuxia/cleanup branch March 21, 2022 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

@xhebox xhebox xhebox approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do tiny cleanup BootstrapSession
6 participants
@zimulala @ti-chi-bot @xhebox @hawkingrei @sre-bot @AilinKid