Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fastrand: optimize Uint32N() #33239

Merged
merged 4 commits into from
Mar 19, 2022
Merged

fastrand: optimize Uint32N() #33239

merged 4 commits into from
Mar 19, 2022

Conversation

zhangyunhao116
Copy link
Contributor

@zhangyunhao116 zhangyunhao116 commented Mar 18, 2022 •
edited
Loading 

name                old time/op  new time/op  delta
FastRandBuf-16      32.5ns ± 4%  18.8ns ± 7%  -42.02%  (p=0.000 n=9+10)
FastRandUint32N-16  0.91ns ± 1%  0.19ns ±12%  -78.83%  (p=0.000 n=9+10)

What problem does this PR solve?

No.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Issue Number: ref #33240

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • ngaut

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-linked-issue size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 18, 2022
@zhangyunhao116
fastrand: optimize Uint32N()
de15b2b 
name                old time/op  new time/op  delta
FastRandBuf-16      32.5ns ± 4%  18.8ns ± 7%  -42.02%  (p=0.000 n=9+10)
FastRandUint32N-16  0.91ns ± 1%  0.19ns ±12%  -78.83%  (p=0.000 n=9+10)

ref pingcap#33239
@zhangyunhao116 zhangyunhao116 changed the title fastrand: imporve Uint32N() fastrand: optimize Uint32N() Mar 18, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 18, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/455cc01df2252622b29757b06cbab0aa2c1c10e0

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 18, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 18, 2022
@ngaut
Copy link
Member

ngaut commented Mar 19, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: de15b2b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 19, 2022
@hawkingrei
Copy link
Member

/run-unit-test

@ti-chi-bot
Copy link
Member

@zhangyunhao116: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit c2eca91 into pingcap:master Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngaut ngaut ngaut approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhangyunhao116 @ti-chi-bot @sre-bot @ngaut @hawkingrei