Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: rewrites some DDL tests #33277

Merged
merged 17 commits into from
Mar 23, 2022
Merged

ddl: rewrites some DDL tests #33277

merged 17 commits into from
Mar 23, 2022

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Mar 21, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #33008

Problem Summary:

What is changed and how it works?

Rewrite some tests.

  1. Move tests to ddl_test as possible.
  2. Use failpoint to mock errors.
  • column_test is totally rewritten and moved to ddl_test.
  • Most of the tests in ddl_worker_test are rewritten and moved to ddl_test.
  • Some tests are kept in ddl package, moved to cancel_ddl_test and other places.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@wjhuang2016
done
f931511 
Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016
refine
5c0e100 
Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016
save-314
bf255c8 
Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016
save
7a85b8d 
Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016
merge
9b47c75 
Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016
save
1ef9a81 
Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016
done
1951813 
Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016
merge
b9053f3 
Signed-off-by: wjhuang2016 <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 21, 2022
@wjhuang2016
refine test
896581d 
Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016
add licence
18b9d43 
Signed-off-by: wjhuang2016 <[email protected]>
hawkingrei
hawkingrei reviewed Mar 21, 2022
View reviewed changes
ddl/fail_test.go Outdated Show resolved Hide resolved
@wjhuang2016
fix import
1582177 
Signed-off-by: wjhuang2016 <[email protected]>
hawkingrei
hawkingrei reviewed Mar 21, 2022
View reviewed changes
ddl/cancel_ddl_test.go
}

func TestDDLSerialSuite(t *testing.T) {
suite.Run(t, new(testDDLSerialSuiteToVerify))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rewrite this test case to remove the suite? suite in the testify doesn't work well #32747 and it will data race.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or wait for this pr merging.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok since there is only one test.

@wjhuang2016
fix check
3d13f36 
Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016
Copy link
Member Author

/run-unit-test

@wjhuang2016
fix test
1d10da3 
Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016
fix test
e106669 
Signed-off-by: wjhuang2016 <[email protected]>
@sre-bot
Copy link
Contributor

sre-bot commented Mar 21, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/5dc12b1bd20462d212cd78c21da660b1721af4bc

xiongjiwei
xiongjiwei reviewed Mar 22, 2022
View reviewed changes
ddl/fail_test.go Outdated Show resolved Hide resolved
ddl/ddl_error_test.go Outdated Show resolved Hide resolved
@wjhuang2016
fix licence
d30fb86 
Signed-off-by: wjhuang2016 <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2022
@hawkingrei
Copy link
Member

/run-unit-test

@wjhuang2016
fix licence
7a93637 
Signed-off-by: wjhuang2016 <[email protected]>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 23, 2022
@xiongjiwei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7a93637

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2022
@ti-chi-bot
Copy link
Member

@wjhuang2016: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 43c0622 into pingcap:master Mar 23, 2022
@wjhuang2016 wjhuang2016 deleted the rewrite_column_test branch November 17, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wjhuang2016 @ti-chi-bot @sre-bot @hawkingrei @xiongjiwei