Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix the wrong rounding behavior of Decimal #33278

Merged
merged 26 commits into from
Apr 2, 2022
Merged

expression: fix the wrong rounding behavior of Decimal #33278

merged 26 commits into from
Apr 2, 2022

Conversation

gengliqi
Copy link
Contributor

@gengliqi gengliqi commented Mar 21, 2022 •
edited
Loading

Signed-off-by: gengliqi [email protected]

What problem does this PR solve?

Issue Number: close #32213

Problem Summary:

What is changed and how it works?

See #32213 and #32213 (comment).
Also, I rename the ModeHalfEven to ModeHalfUp because ModeHalfEven is the wrong name for this rounding behavior. (See https://dev.mysql.com/doc/refman/5.7/en/precision-math-rounding.html).

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

expression: fix the wrong rounding behavior of Decimal

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • guo-shaoge

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-4.0 needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 21, 2022
@gengliqi
Copy link
Contributor Author

/cc @XuHuaiyu @wshwsh12 @guo-shaoge

@gengliqi
update comments
4454abe 
Signed-off-by: gengliqi <[email protected]>
@gengliqi
Copy link
Contributor Author

gengliqi commented Mar 21, 2022 •
edited
Loading

TestStringtoDecimal failed. Seems the ErrTruncatedWrongVal should not be removed here.

@gengliqi
Copy link
Contributor Author

TestStringtoDecimal failed. Seems the ErrTruncatedWrongVal should not be removed here.

I change it back. PTAL

@gengliqi
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 24, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/bd2501608f2b73cbccebb28f31405d5b65945239

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 28, 2022
XuHuaiyu
XuHuaiyu reviewed Mar 28, 2022
View reviewed changes
types/datum_test.go Outdated Show resolved Hide resolved
types/datum.go Outdated Show resolved Hide resolved
@fzhedu
Copy link
Contributor

fzhedu commented Apr 1, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e1ffc4a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 1, 2022
@gengliqi
Copy link
Contributor Author

gengliqi commented Apr 2, 2022

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 0beac18 into pingcap:master Apr 2, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 2, 2022
@gengliqi @ti-srebot
cherry pick pingcap#33278 to release-4.0
4c826e9 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 2, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #33668

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 2, 2022
@gengliqi @ti-srebot
cherry pick pingcap#33278 to release-5.0
3b9c140 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 2, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #33669

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 2, 2022
@gengliqi @ti-srebot
cherry pick pingcap#33278 to release-5.1
05c17fe 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 2, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #33670

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 2, 2022
@gengliqi @ti-srebot
cherry pick pingcap#33278 to release-5.2
a8a3921 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 2, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #33671

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 2, 2022
@gengliqi @ti-srebot
cherry pick pingcap#33278 to release-5.3
e922c26 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 2, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33672

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 2, 2022
@gengliqi @ti-srebot
cherry pick pingcap#33278 to release-5.4
291037d 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 2, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33673

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 2, 2022
@gengliqi @ti-srebot
cherry pick pingcap#33278 to release-6.0
52884cf 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 2, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
do-not-merge/cherry-pick-not-approved needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong result for cast expr when value exceeds range
8 participants
@gengliqi @ti-chi-bot @sre-bot @XuHuaiyu @fzhedu @ti-srebot @guo-shaoge @VelocityLight