Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix "can't find column" when projection wrongly added above index lookup reader after agg pushed down #33287

Merged
merged 5 commits into from
Mar 22, 2022
Merged

planner: fix "can't find column" when projection wrongly added above index lookup reader after agg pushed down #33287

merged 5 commits into from
Mar 22, 2022

Conversation

time-and-fate
Copy link
Member

What problem does this PR solve?

Issue Number: close #33237

Problem Summary:

Very similar to #23804, a projection was added between the partial agg and the final agg, and the schema between them was broken.
But #23804 is for PhysicalTableReader, this case is PhysicalIndexLookUpReader.

What is changed and how it works?

Don't inject the extra projection if the agg was pushed down.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • winoros
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 21, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 21, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/aed46a917db614e1bad295c8c209ae7ef5e2d507

@time-and-fate time-and-fate mentioned this pull request Mar 21, 2022
Merged
12 tasks
wjhuang2016
wjhuang2016 reviewed Mar 22, 2022
View reviewed changes
planner/core/integration_test.go Outdated
@@ -6243,3 +6243,14 @@ func TestTiFlashPartitionTableScan(t *testing.T) {
tk.MustExec("drop table rp_t;")
tk.MustExec("drop table hp_t;")
}

func TestIssue33237(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can push these test to explain test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Moved it to explain.test.

winoros
winoros approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a case that can be solved after projection pushdown with full built-in function support.
Now we have projection soon, but when would we have full built-in function support?

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 22, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 22, 2022
@time-and-fate
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: db79a6d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 22, 2022
@time-and-fate
Copy link
Member Author

/run-cla

@time-and-fate
Copy link
Member Author

/run-check-cla

@ti-chi-bot ti-chi-bot merged commit 9f72bcd into pingcap:master Mar 22, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 22, 2022
@time-and-fate @ti-srebot
cherry pick pingcap#33287 to release-6.0
e70aa5e 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 22, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
6 participants
@time-and-fate @ti-chi-bot @sre-bot @ti-srebot @winoros @wjhuang2016