Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: forbid plan cache in stale read (#33273) #33301

Merged
merged 3 commits into from
Mar 25, 2022
Merged

session: forbid plan cache in stale read (#33273) #33301

merged 3 commits into from
Mar 25, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 22, 2022 •
edited
Loading

cherry-pick #33273 to release-6.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/33301

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/33301:release-6.0-bd008d240bee

Signed-off-by: yisaer [email protected]

What problem does this PR solve?

Issue Number: close #31550

Problem Summary:

Forbid plan cache in stale read

What is changed and how it works?

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 22, 2022
@ti-srebot ti-srebot mentioned this pull request Mar 22, 2022
Merged
1 task
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/6.0-cherry-pick labels Mar 22, 2022
@ti-srebot
Copy link
Contributor Author

@Yisaer you're already a collaborator in bot's repo.

AilinKid
AilinKid approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 24, 2022
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 25, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 25, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/66181bd261b083b5086c0cf118b03217dbe76ad2

@Yisaer
Copy link
Contributor

Yisaer commented Mar 25, 2022

/run-mysql-test

@Yisaer
Copy link
Contributor

Yisaer commented Mar 25, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 66181bd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2022
@Yisaer
Copy link
Contributor

Yisaer commented Mar 25, 2022

/run-mysql-test

1 similar comment
@Yisaer
Copy link
Contributor

Yisaer commented Mar 25, 2022

/run-mysql-test

@Yisaer
Copy link
Contributor

Yisaer commented Mar 25, 2022

/run-unit-test

1 similar comment
@Yisaer
Copy link
Contributor

Yisaer commented Mar 25, 2022

/run-unit-test

@Yisaer
Copy link
Contributor

Yisaer commented Mar 25, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit eda2f72 into pingcap:release-6.0 Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

@JmPotato JmPotato JmPotato approved these changes

@lcwangchao lcwangchao Awaiting requested review from lcwangchao

Assignees

@Yisaer Yisaer

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/6.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @ti-chi-bot @sre-bot @Yisaer @JmPotato @AilinKid @VelocityLight