planner: fix the join scope with explicit parents #33311
Conversation
Signed-off-by: AilinKid <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9143f15d07d3fd3dc0fffef1f2e2158bf46aeaeb |
Signed-off-by: AilinKid <[email protected]>
| @@ -229,11 +229,11 @@ func TestJoinRestore(t *testing.T) { | |||
| //{"(select a from t) t1 join t t2, t3;", "((SELECT `a` FROM `t`) AS `t1` JOIN `t` AS `t2`) JOIN `t3`"}, | |||
| } | |||
| testChangedCases := []NodeRestoreTestCase{ | |||
| {"(a al left join b bl on al.a1 > bl.b1) join (a ar right join b br on ar.a1 > br.b1)", "((`a` AS `al` LEFT JOIN `b` AS `bl` ON `al`.`a1`>`bl`.`b1`) JOIN `b` AS `br`) LEFT JOIN `a` AS `ar` ON `ar`.`a1`>`br`.`b1`"}, | |||
| {"(a al left join b bl on al.a1 > bl.b1) join (a ar right join b br on ar.a1 > br.b1)", "(`a` AS `al` LEFT JOIN `b` AS `bl` ON `al`.`a1`>`bl`.`b1`) JOIN (`a` AS `ar` RIGHT JOIN `b` AS `br` ON `ar`.`a1`>`br`.`b1`)"}, | |||
There was a problem hiding this comment.
Why not add the new test cases?
There was a problem hiding this comment.
The changed part is the output, instead of the input,
winoros
changed the title
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 569a7ad
|
ti-chi-bot
added
the
status/can-merge
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-5.0 in PR #33413 |
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-5.1 in PR #33414 |
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-5.2 in PR #33415 |
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-5.3 in PR #33416 |
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-5.4 in PR #33417 |
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-6.0 in PR #33418 |
Signed-off-by: AilinKid [email protected]
What problem does this PR solve?
Issue Number: close #31770
Problem Summary:
What is changed and how it works?
after this pingcap/parser#1129, tidb parser will reorganize join table regardless the explicit parents
Eg: t1 join (t2 join t3) will be reorged as (t1 join t2) join t3
parser/1129 seek to solve the problem
1: with no explicit parents join sequence like: t1 join t2 join t3, make them left-associative
2: with explicit parents and can be reorder the join sequece, like: a join b right join c, we find it here, change the right join as left join, then with the logical semantic same, rewrite it as a join c left join b
Although it's a nice idea, we still has something to do before that, like name resolution in parents scope. like:
select t1.* from t t0 cross join (t t1 join t t2 on 100=t0.a)t0.a here shouldn't be seen by the join inside. But after it's rewrite it's different
select t1.* from (t t0 cross join t t1) join t t2 on 100=t0.athis kind of join reorder can be detected and improved in logical optimization.
Check List
Tests
Side effects
Documentation
Release note