Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: fix race in test Test(Split|Restore)Failed #33313

Merged
merged 8 commits into from
Mar 23, 2022
Merged

br: fix race in test Test(Split|Restore)Failed #33313

merged 8 commits into from
Mar 23, 2022

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Mar 22, 2022 •
edited
Loading

Signed-off-by: Yu Juncen [email protected]

What problem does this PR solve?

Issue Number: close #33310

Problem Summary:

See the issue.

What is changed and how it works?

Added a lock for eliminating the race condition.

Check List

Tests

  • Unit test

image

  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

(This is a fix over test cases. I guess there is no meaning for adding release notes...)

None

@YuJuncen
fix pingcap#33310
d4b85b3 
Signed-off-by: Yu Juncen <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 22, 2022
@hawkingrei
Copy link
Member

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-6.0 and removed do-not-merge/needs-triage-completed labels Mar 22, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 22, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/f0ab3e9f9b7d2f65b7f01798b5e2440756ebeb72

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 23, 2022
@3pointer
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: db02c28

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2022
@YuJuncen
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit e2ad790 into pingcap:master Mar 23, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 23, 2022
@YuJuncen @ti-srebot
cherry pick pingcap#33313 to release-5.3
51f2eb4 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 23, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33339

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 23, 2022
@YuJuncen @ti-srebot
cherry pick pingcap#33313 to release-5.4
e1e820d 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 23, 2022
Open
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33340

@ti-srebot ti-srebot mentioned this pull request Mar 23, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33341

YuJuncen added a commit to ti-srebot/tidb that referenced this pull request Mar 25, 2022
@YuJuncen
br: fix race in test Test(Split|Restore)Failed (pingcap#33313)
4cf121d 
close pingcap#33310
ti-chi-bot pushed a commit that referenced this pull request Mar 25, 2022
@ti-srebot
br: fix race in test Test(Split|Restore)Failed (#33313) (#33341)
ca0e9a0 
close #33310
ti-chi-bot pushed a commit that referenced this pull request Jun 17, 2022
@ti-srebot
br: fix race in test Test(Split|Restore)Failed (#33313) (#33339)
7645ba2 
close #33310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@3pointer 3pointer 3pointer approved these changes

@kennytm kennytm Awaiting requested review from kennytm

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DATA RACE in the NewTiKVSender
6 participants
@YuJuncen @ti-chi-bot @hawkingrei @sre-bot @3pointer @ti-srebot