Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: Enhance task field for explain/explain analyze #33333

Merged
merged 12 commits into from
Mar 29, 2022
Merged

executor: Enhance task field for explain/explain analyze #33333

merged 12 commits into from
Mar 29, 2022

Conversation

windtalker
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #33332

Problem Summary:

What is changed and how it works?

  • add a new task type named mpp in explain/explain analyze
  • refine code about SetMppOrBatchCopForTableScan

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

In `explain/explain analyze`, add `mpp[tiflash]` task type for `task` field

@windtalker
enhance task type in explain
52d16c9 
Signed-off-by: xufei <[email protected]>
@windtalker
refine code
798f33a 
Signed-off-by: xufei <[email protected]>
@windtalker
refine
2944bc0 
Signed-off-by: xufei <[email protected]>
@windtalker
refine
e9b74e8 
Signed-off-by: xufei <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 23, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 23, 2022
@windtalker
fix ci
e12fa86 
Signed-off-by: xufei <[email protected]>
@windtalker
fix ci
7b2a65a 
Signed-off-by: xufei <[email protected]>
@windtalker
fix ci
8e09000 
Signed-off-by: xufei <[email protected]>
@sre-bot
Copy link
Contributor

sre-bot commented Mar 23, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/83e009faf5944d38249cc4300d20e4be367dee8c

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 23, 2022
@windtalker
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 28, 2022
@windtalker
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9a558f1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2022
@windtalker
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit c58e005 into pingcap:master Mar 29, 2022
@windtalker windtalker deleted the enhance_task_type_in_explain branch May 24, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleFall LittleFall LittleFall approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance task field for explain/explain analyze
5 participants
@windtalker @ti-chi-bot @sre-bot @wshwsh12 @LittleFall