-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: raise error when text data is too long #33345
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/5b5bcb7fab60cd32bca1bafd0245f27d2a8af502 |
@Jasonysli the title should be formatted: https://ci.pingcap.net/blue/organizations/jenkins/tidb_check_title/detail/tidb_check_title/49256/pipeline I've updated it for you, FYI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is a compatibility breaker, so I added the label and updated the checklist. |
Please write a release note. Rest LGTM. |
/merge |
@tangenta: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 0a726f6
|
@Jasonysli: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
fix #32601
What problem does this PR solve?
#32601
Issue Number: 32601
datum.pkg was changed.
Problem Summary:
What is changed and how it works?
1.Under strict sql_mode, raise error when blob,text data is too long;
2.Under non-strict sql_mode, truncate the data when data is too long instead of error;
Check List
Tests
Side effects
Documentation
Release note
Issue Number: close #32601