Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix unstable test TestPlanCacheWithStaleReadByBinaryProto #33351

Merged
merged 6 commits into from
Mar 24, 2022
Merged

executor: fix unstable test TestPlanCacheWithStaleReadByBinaryProto #33351

merged 6 commits into from
Mar 24, 2022

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Mar 23, 2022 •
edited
Loading

Signed-off-by: yisaer [email protected]

What problem does this PR solve?

Issue Number: close #33349

Problem Summary:

What is changed and how it works?

TestPlanCacheWithStaleReadByBinaryProto is unstable due to local time skew error, this request fixed it.

I run go test -run TestPlanCacheWithStaleReadByBinaryProto -count 10 locally, the result is pass as expected.

Check List

Tests

  • Unit test

Release note

None

@Yisaer
fix unstable test
b809c3c 
Signed-off-by: yisaer <[email protected]>
@Yisaer
Revert "fix unstable test"
ae5669e 
This reverts commit b809c3c.
@Yisaer
fix unstable test
96f12f6 
Signed-off-by: yisaer <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 23, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 23, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 23, 2022

/run-check-issue-triage-complete

@sre-bot
Copy link
Contributor

sre-bot commented Mar 23, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b4bf6cb84068d2d5abc5591f34202c9df02053d4

@Yisaer
address the comment
74ca71c 
Signed-off-by: yisaer <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 24, 2022
@qw4990
Copy link
Contributor

qw4990 commented Mar 24, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c461906

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2022
@qw4990
Copy link
Contributor

qw4990 commented Mar 24, 2022

/merge

@ti-chi-bot ti-chi-bot merged commit 1df16c0 into pingcap:master Mar 24, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 24, 2022
@Yisaer @ti-srebot
cherry pick pingcap#33351 to release-6.0
6b3f510 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 24, 2022
Closed
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@qw4990 qw4990 qw4990 approved these changes

@lcwangchao lcwangchao Awaiting requested review from lcwangchao

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unstable test TestPlanCacheWithStaleReadByBinaryProto
7 participants
@Yisaer @ti-chi-bot @sre-bot @qw4990 @ti-srebot @lcwangchao @JmPotato