Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: Add comment to filterRestoreFiles function #33353

Merged
merged 2 commits into from
Mar 24, 2022
Merged

br: Add comment to filterRestoreFiles function #33353

merged 2 commits into from
Mar 24, 2022

Conversation

WangLe1321
Copy link
Contributor

@WangLe1321 WangLe1321 commented Mar 23, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #33352

Problem Summary:

What is changed and how it works?

This adds a comment to filterRestoreFiles function, to explain it's effect.

Check List

Tests

  • No code

Release note

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 23, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • joccau

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 23, 2022
@CLAassistant
Copy link

CLAassistant commented Mar 23, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 23, 2022
@WangLe1321
Copy link
Contributor Author

/cc @3pointer

@WangLe1321
Copy link
Contributor Author

/cc @joccau

@ti-chi-bot ti-chi-bot requested a review from joccau March 23, 2022 11:10
@sre-bot
Copy link
Contributor

sre-bot commented Mar 23, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/424729a2c7e8037d5056f6ba9591c24dd3629f29

joccau
joccau approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 23, 2022
bb7133
bb7133 approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Mar 23, 2022

/merge

@ti-chi-bot
Copy link
Member

@bb7133: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 23, 2022
@hawkingrei
Copy link
Member

/merge

@hawkingrei
Copy link
Member

@WangLe1321 Your commits have different usernames. so you should keep it consistent.

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 24, 2022
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 24, 2022
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fc64684

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2022
@ti-chi-bot
Copy link
Member

@WangLe1321: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 815a537 into pingcap:master Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@joccau joccau joccau approved these changes

@3pointer 3pointer Awaiting requested review from 3pointer

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

br: there is no comment of function filterRestoreFiles
7 participants
@WangLe1321 @ti-chi-bot @CLAassistant @sre-bot @bb7133 @hawkingrei @joccau