Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: fix wrong point range in crossValidationSelectivity #33357

Merged
merged 3 commits into from
Mar 28, 2022
Merged

statistics: fix wrong point range in crossValidationSelectivity #33357

merged 3 commits into from
Mar 28, 2022

Conversation

xuyifangreeneyes
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #28030

Problem Summary:
Fix the second problem described in #28030.

What is changed and how it works?

When we calculate the selectivity of multi-column equal conditions in crossValidationSelectivity, we construct the point range to calculate the selectivity for each column that has the equal condition, and then multiply these selectivities to get the final selectivity. However, we have a tiny fault when constructing the point range for each column, which is that we don't correctly set LowExclude/HighExclude. Since the column range is point range(LowVal is equal to HighVal), we need to set both LowExclude and HighExclude to false. Otherwise we would get 0.0 estRow.

You can try the unit test on master and will find the test fails. On master the optimizer thinks estRow of TableRangeScan is 0.00 rather than 2.00, which is wrong estimation.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 23, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • time-and-fate
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 23, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 23, 2022
@xuyifangreeneyes
Copy link
Contributor Author

/cc @time-and-fate @winoros

@xuyifangreeneyes
Copy link
Contributor Author

/cherry-pick

@xuyifangreeneyes
Copy link
Contributor Author

/help

@xuyifangreeneyes
Copy link
Contributor Author

/cherry-pick-5.0

@xuyifangreeneyes
Copy link
Contributor Author

/label needs-cherry-pick-5.0

@xuyifangreeneyes
Copy link
Contributor Author

/label needs-cherry-pick-5.1

@xuyifangreeneyes
Copy link
Contributor Author

/label needs-cherry-pick-5.2

@xuyifangreeneyes
Copy link
Contributor Author

/label needs-cherry-pick-5.3

@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 label Mar 24, 2022
@xuyifangreeneyes
Copy link
Contributor Author

/label needs-cherry-pick-5.4

@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Mar 24, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 24, 2022
@xuyifangreeneyes
Copy link
Contributor Author

/run-unit-test

@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f63db1c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 28, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 28, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9dc85cb659b10c100cdc365c8ab0b5adcbb08588

@ti-chi-bot ti-chi-bot merged commit c671ebc into pingcap:master Mar 28, 2022
@ti-srebot ti-srebot mentioned this pull request Mar 28, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 28, 2022
@xuyifangreeneyes @ti-srebot
cherry pick pingcap#33357 to release-5.0
b6bf5d1 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #33486

@ti-srebot ti-srebot mentioned this pull request Mar 28, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 28, 2022
@xuyifangreeneyes @ti-srebot
cherry pick pingcap#33357 to release-5.1
b3a99f0 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #33487

@ti-srebot ti-srebot mentioned this pull request Mar 28, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 28, 2022
@xuyifangreeneyes @ti-srebot
cherry pick pingcap#33357 to release-5.2
afecb5b 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #33488

@ti-srebot ti-srebot mentioned this pull request Mar 28, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 28, 2022
@xuyifangreeneyes @ti-srebot
cherry pick pingcap#33357 to release-5.3
1f4e6e3 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33489

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 28, 2022
@xuyifangreeneyes @ti-srebot
cherry pick pingcap#33357 to release-5.4
da3e0a5 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 28, 2022
Open
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33490

@xuyifangreeneyes xuyifangreeneyes deleted the cross-validate branch March 28, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@xuyifangreeneyes @ti-chi-bot @Reminiscent @sre-bot @ti-srebot @winoros @time-and-fate