-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix warnings message when alter table nocache and cache again #33358
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-unit-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b40fd5f
|
@tiancaiamao: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b40fd5f4d2bfbb5955ec0e4424579761b185c1d7 |
What problem does this PR solve?
Issue Number: close #32692
Problem Summary:
What is changed and how it works?
'insert ignore into' will get a warning when the key exists, so use 'replace into' instead.
alter table cache -> alter table no cache -> alter table cache
The row already exists in the
mysql.table_cache_meta
, so 'insert ignore into' will get the warnings.Alternative solution: let
alter table no cache
delete the record from themysql.table_cache_meta
...But this is not safe when there are more than one client do it concurrently.
Check List
Tests
Side effects
Documentation
Release note