Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor, infoschema: Add foreign key constraint to infoschema.table_constraints #33360

Merged
merged 7 commits into from
Mar 25, 2022

Conversation

espresso98
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #28918

Problem Summary:

This adds foreign key constraints to the infoschema table table_constraints. The output is MySQL compatible.

What is changed and how it works?

This adds foreign key constraints to the infoschema table table_constraints. The output is MySQL compatible.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility
    It improves compatibility

Release note

 The infoschema table `table_constraints` now includes the output of foreign key constraints. Please note  FOREIGN KEY constraints are not still enforced by TiDB. 

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 23, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 23, 2022
@espresso98
Copy link
Collaborator Author

/cc @morgo

@ti-chi-bot ti-chi-bot requested a review from morgo March 23, 2022 17:34
@sre-bot
Copy link
Contributor

sre-bot commented Mar 23, 2022

@morgo
Copy link
Contributor

morgo commented Mar 23, 2022

/check-issue-triage-complete

1 similar comment
@morgo
Copy link
Contributor

morgo commented Mar 23, 2022

/check-issue-triage-complete

Copy link
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 23, 2022
@morgo
Copy link
Contributor

morgo commented Mar 23, 2022

/run-unit-test

1 similar comment
@hawkingrei
Copy link
Member

/run-unit-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 25, 2022
@Defined2014
Copy link
Contributor

/run-mysql-test

1 similar comment
@Defined2014
Copy link
Contributor

/run-mysql-test

@Defined2014
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 88708af

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2022
@hawkingrei
Copy link
Member

/run-unit-test

@hawkingrei
Copy link
Member

/run-check_title

@ti-chi-bot
Copy link
Member

@espresso98: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit c5a0737 into pingcap:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INFORMATION_SCHEMA.table_constraints does not show foreign key constraint
6 participants