Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infoschema: stabalize TestSelectClusterTable test (#33295) #33366

Merged
merged 6 commits into from
Mar 25, 2022
Merged

infoschema: stabalize TestSelectClusterTable test (#33295) #33366

merged 6 commits into from
Mar 25, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 24, 2022 •
edited
Loading

cherry-pick #33295 to release-6.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/33366

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/33366:release-6.0-6c28e0e938dc

What problem does this PR solve?

Issue Number: close #33294

Problem Summary:

The infoschema tests are unstable. This is caused by the HOST portion of the processlist now including the peer port (from #30183 ). The solution is just to not include this in the results.

What is changed and how it works?

Fixed tests only.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 24, 2022
@ti-srebot ti-srebot mentioned this pull request Mar 24, 2022
Merged
12 tasks
@ti-srebot ti-srebot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/6.0-cherry-pick labels Mar 24, 2022
@ti-srebot
Copy link
Contributor Author

@morgo you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 24, 2022
@hawkingrei
Copy link
Member

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 24, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ab5b7e881be5c89aae5b0244641ac3152d30824c

@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 24, 2022
@VelocityLight
Copy link

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cdfc543

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2022
@hawkingrei
Copy link
Member

/run-unit-test

@hawkingrei
Copy link
Member

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 310fe55 into pingcap:release-6.0 Mar 25, 2022
@hawkingrei hawkingrei deleted the release-6.0-6c28e0e938dc branch March 25, 2022 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@mjonss mjonss Awaiting requested review from mjonss

Assignees

@morgo morgo

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/6.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @ti-chi-bot @hawkingrei @sre-bot @VelocityLight @wjhuang2016 @morgo