Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expr: add function push down results comparing testcase #33401

Merged
merged 6 commits into from
Mar 25, 2022
Merged

expr: add function push down results comparing testcase #33401

merged 6 commits into from
Mar 25, 2022

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Mar 24, 2022

Signed-off-by: yisaer [email protected]

What problem does this PR solve?

Issue Number: close #33391

Problem Summary:

What is changed and how it works?

remove high risk functions push down and add number function results comparing testcase

Check List

Tests

  • Unit test
  • Integration test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-cherry-pick-6.0 size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 24, 2022
@Yisaer
add testcase
d54d51c 
Signed-off-by: yisaer <[email protected]>

add testcase

Signed-off-by: yisaer <[email protected]>

add testcase

Signed-off-by: yisaer <[email protected]>

add testcase

Signed-off-by: yisaer <[email protected]>

add testcase

Signed-off-by: yisaer <[email protected]>
@Yisaer Yisaer marked this pull request as ready for review March 24, 2022 14:27
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 24, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/2b76d48c3b5be6f470cba1f7aeb43cd8005d7ab4

@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 24, 2022

/run-mysql-test

4 similar comments
@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 24, 2022

/run-mysql-test

@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 24, 2022

/run-mysql-test

@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 24, 2022

/run-mysql-test

@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 24, 2022

/run-mysql-test

@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 24, 2022

/run-check_dev_2

1 similar comment
@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 24, 2022

/run-check_dev_2

@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 24, 2022

/run-mysql-test

1 similar comment
@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 24, 2022

/run-mysql-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2022
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2022
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 25, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 25, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2b76d48

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 25, 2022

/run-uni-test

1 similar comment
@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 25, 2022

/run-uni-test

@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 25, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit ca0ade0 into pingcap:master Mar 25, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 25, 2022
@Yisaer @ti-srebot
cherry pick pingcap#33401 to release-6.0
ae6b30d 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 25, 2022
Merged
2 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33412

ti-chi-bot pushed a commit that referenced this pull request Mar 25, 2022
@ti-srebot
expr: add function push down results comparing testcase (#33401) (#33412
a270c1a 
)

close #33391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelice rebelice rebelice approved these changes

@JmPotato JmPotato JmPotato approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the results of ord function pushed down to tikv is different with tidb
6 participants
@Yisaer @ti-chi-bot @sre-bot @ti-srebot @JmPotato @rebelice