Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix the missing retry for pd batch scan error (#33420) #33467

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 25, 2022

cherry-pick #33420 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/33467

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/33467:release-5.1-9129590f5b0c

What problem does this PR solve?

Issue Number: close #33419

Problem Summary:
current BR doesn't not retry ErrPDBatchScanRegion enough.

What is changed and how it works?

replace the multierr with the ErrPDBatchScanRegion

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the issue that BR not retry enough when region not consistency during restoration.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 25, 2022
@ti-srebot ti-srebot added cherry-pick-approved Cherry pick PR approved by release team. component/br This issue is related to BR of TiDB. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.1-cherry-pick labels Mar 25, 2022
@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Mar 25, 2022
@ti-srebot ti-srebot added this to the v5.1.4 milestone Mar 25, 2022
@ti-chi-bot ti-chi-bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 25, 2022
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 25, 2022
@ti-srebot
Copy link
Contributor Author

@3pointer you're already a collaborator in bot's repo.

@3pointer 3pointer closed this Mar 25, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved and removed do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. labels Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/br This issue is related to BR of TiDB. do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/5.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants