-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix the view with use index do not result error issue #33474
Conversation
Signed-off-by: fanrenhoo <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/cc @xhebox |
/run-unit-test |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/854eb285df9899d5696ffa63c948ff6d1239f892 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 63ebb6e
|
@fanrenhoo: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-mysql-test |
Signed-off-by: fanrenhoo [email protected]
What problem does this PR solve?
Issue Number: close #32683
Problem Summary: the view should not have index, SELECT ... FROM USE INDEX (...) should result error
What is changed and how it works?
during "select stmt" buildDataSource, the use index availability should be checked before goes to the source table data link, now fixed, works fine now.
Check List
Tests
Unit test
Integration test
Manual test (add detailed scripts or steps below)
mysql>drop table if exists t1;
mysql>drop view if exists v1,v2;
mysql>CREATE TABLE t1 (c1 INT PRIMARY KEY, c2 INT, INDEX (c2));
mysql>INSERT INTO t1 VALUES (1,1), (2,2), (3,3);
mysql>CREATE VIEW v1 AS SELECT c1, c2 FROM t1;
mysql>SELECT * FROM v1 USE INDEX (PRIMARY) WHERE c1=2;
mysql> SELECT * FROM v1 USE INDEX (PRIMARY) WHERE c1=2;
ERROR 1176 (42000): Key 'PRIMARY' doesn't exist in table 'v1'
No code
Side effects
no
Documentation
no
Release note