Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix the view with use index do not result error issue #33474

Merged
merged 2 commits into from
Mar 26, 2022

Conversation

fanrenhoo
Copy link
Contributor

Signed-off-by: fanrenhoo [email protected]

What problem does this PR solve?

Issue Number: close #32683

Problem Summary: the view should not have index, SELECT ... FROM USE INDEX (...) should result error

What is changed and how it works?

during "select stmt" buildDataSource, the use index availability should be checked before goes to the source table data link, now fixed, works fine now.

Check List

Tests

  • Unit test

  • Integration test

  • Manual test (add detailed scripts or steps below)
    mysql>drop table if exists t1;
    mysql>drop view if exists v1,v2;
    mysql>CREATE TABLE t1 (c1 INT PRIMARY KEY, c2 INT, INDEX (c2));
    mysql>INSERT INTO t1 VALUES (1,1), (2,2), (3,3);
    mysql>CREATE VIEW v1 AS SELECT c1, c2 FROM t1;
    mysql>SELECT * FROM v1 USE INDEX (PRIMARY) WHERE c1=2;
    mysql> SELECT * FROM v1 USE INDEX (PRIMARY) WHERE c1=2;
    ERROR 1176 (42000): Key 'PRIMARY' doesn't exist in table 'v1'

  • No code

Side effects
no

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation
no

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the view with use index do not result error issue#32683, now select stmt for view with use index will result error as mysql does

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 26, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 26, 2022
@fanrenhoo
Copy link
Contributor Author

/cc @xhebox

@ti-chi-bot ti-chi-bot requested a review from xhebox March 26, 2022 01:51
@hawkingrei
Copy link
Member

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Mar 26, 2022

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 26, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 26, 2022
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 63ebb6e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 26, 2022
@ti-chi-bot
Copy link
Member

@fanrenhoo: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit e5d3e22 into pingcap:master Mar 26, 2022
@fanrenhoo fanrenhoo deleted the viewshouldnothaveindex branch March 26, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

view's don't have index, SELECT ... FROM <view> USE INDEX (...) should result error
5 participants