Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb-binlog/driver/reader: migrate test-infra to testify #33480

Merged
merged 2 commits into from
Mar 27, 2022
Merged

tidb-binlog/driver/reader: migrate test-infra to testify #33480

merged 2 commits into from
Mar 27, 2022

Conversation

zanpocc
Copy link
Contributor

@zanpocc zanpocc commented Mar 27, 2022

What problem does this PR solve?

Issue Number: close #33461

Problem Summary: migrate test-infra to testify

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 27, 2022
hawkingrei
hawkingrei reviewed Mar 27, 2022
View reviewed changes
tidb-binlog/driver/reader/offset_test.go Outdated
producer sarama.SyncProducer
config *sarama.Config
addr string
available bool
topic string
}

func (to *testOffsetSuite) SetUpSuite(c *C) {
func TestClient(t *testing.T) {
suite.Run(t, new(testOffsetSuite))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please not use the suite. it will cause the data race in #32747.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I will revise it, mainly because I see that suite is also written in the tidb project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok with only one test, if there are multiple tests, should I call the setup function before each test?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I will revise it, mainly because I see that suite is also written in the tidb project.

the other test case have been in the plan that they will be rewritten.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok with only one test, if there are multiple tests, should I call the setup function before each test?

Yes, You can.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sre-bot
Copy link
Contributor

sre-bot commented Mar 27, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/a12b28023507739b1027a219a6b5806f2b64bc2e

@zanpocc zanpocc force-pushed the restructure_tests_tidb-binlog_reader branch from 6070a61 to bfda610 Compare March 27, 2022 10:12
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 27, 2022
@zanpocc zanpocc marked this pull request as draft March 27, 2022 10:18
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2022
@zanpocc zanpocc closed this Mar 27, 2022
@zanpocc zanpocc force-pushed the restructure_tests_tidb-binlog_reader branch from bfda610 to e09bc29 Compare March 27, 2022 10:20
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 27, 2022
@zanpocc zanpocc reopened this Mar 27, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 27, 2022
@zanpocc zanpocc marked this pull request as ready for review March 27, 2022 10:28
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2022
@zanpocc zanpocc requested a review from hawkingrei March 27, 2022 10:29
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 27, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 27, 2022
@tisonkun tisonkun changed the title tidb-binlog/reader: migrate test-infra to testify for offset_test.go tidb-binlog/driver/reader: migrate test-infra to testify for offset_test.go Mar 27, 2022
@tisonkun tisonkun changed the title tidb-binlog/driver/reader: migrate test-infra to testify for offset_test.go tidb-binlog/driver/reader: migrate test-infra to testify Mar 27, 2022
@tisonkun
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a12b280

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 27, 2022
@ti-chi-bot ti-chi-bot merged commit 32559db into pingcap:master Mar 27, 2022
@zanpocc zanpocc deleted the restructure_tests_tidb-binlog_reader branch March 28, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for tidb-binlog/driver/reader pkg
5 participants
@zanpocc @ti-chi-bot @sre-bot @tisonkun @hawkingrei