Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "topsql: enable topsql feature by default (#33195)" (#33493) #33522

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Revert "topsql: enable topsql feature by default (#33195)" (#33493) #33522

merged 2 commits into from
Mar 29, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 28, 2022 •
edited
Loading

cherry-pick #33493 to release-6.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/33522

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/33522:release-6.0-5c931aadc8bd

This reverts commit 44cf398.

What problem does this PR solve?

Issue Number: close #33492

Problem Summary: Disable TopSQL by default since the performance regression is too large

What is changed and how it works?

Check List

Tests

Release note

None

@ti-srebot ti-srebot requested a review from a team as a code owner March 28, 2022 14:46
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Mar 28, 2022
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 28, 2022
@ti-srebot ti-srebot mentioned this pull request Mar 28, 2022
Merged
@ti-srebot
Copy link
Contributor Author

@crazycs520 you're already a collaborator in bot's repo.

@sre-bot
Copy link
Contributor

sre-bot commented Mar 28, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/90c3e6a8c3c82d9945bffc8622c6f6ae8c75b54b

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 28, 2022
@breezewish
Copy link
Member

/run-all-tests

@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 29, 2022
@breezewish
Copy link
Member

/run-all-tests

@breezewish
Copy link
Member

/run-mysql-test

1 similar comment
@breezewish
Copy link
Member

/run-mysql-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 29, 2022
@breezewish
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: af63eee

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2022
@hawkingrei
Copy link
Member

/run-mysql-test

@breezewish
Copy link
Member

/run-mysql-test

@breezewish
Copy link
Member

/run-unit-test

1 similar comment
@breezewish
Copy link
Member

/run-unit-test

@hawkingrei
Copy link
Member

/run-mysql-test

2 similar comments
@breezewish
Copy link
Member

/run-mysql-test

@breezewish
Copy link
Member

/run-mysql-test

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2022
@breezewish
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 90c3e6a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2022
@breezewish
Copy link
Member

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 6f28ac4 into pingcap:release-6.0 Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@breezewish breezewish breezewish approved these changes

@zhongzc zhongzc Awaiting requested review from zhongzc

Assignees

@crazycs520 crazycs520

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/6.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ti-srebot @ti-chi-bot @sre-bot @breezewish @hawkingrei @qw4990 @VelocityLight @crazycs520