executor: migrate test-infra to testify for executor_test.go testSlowQuerySuite

[tisonkun]

Issue Number: close #33439

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• hawkingrei
• xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[tisonkun]

/cc @hawkingrei @djshow832

[hawkingrei]

/run-check_dev
/run-unit-test

[crazycs520]

@tisonkun You can fix the test by add following change

diff --git a/executor/slow_query_sql_test.go b/executor/slow_query_sql_test.go
index 63aaeaeadb..fc4593bbb2 100644
--- a/executor/slow_query_sql_test.go
+++ b/executor/slow_query_sql_test.go
@@ -15,6 +15,7 @@
 package executor_test

 import (
+       "fmt"
        "math"
        "os"
        "testing"
@@ -61,6 +62,7 @@ func TestSlowQuerySensitiveQuery(t *testing.T) {
        }()
        require.NoError(t, logutil.InitLogger(newCfg.Log.ToLogConfig()))

+       tk.MustExec(fmt.Sprintf("set @@tidb_slow_query_file='%v'", f.Name()))
        tk.MustExec("set tidb_slow_log_threshold=0;")
        tk.MustExec("drop user if exists user_sensitive;")
        tk.MustExec("create user user_sensitive identified by '123456789';")
@@ -96,6 +98,7 @@ func TestSlowQueryPrepared(t *testing.T) {
        }()
        require.NoError(t, logutil.InitLogger(newCfg.Log.ToLogConfig()))

+       tk.MustExec(fmt.Sprintf("set @@tidb_slow_query_file='%v'", f.Name()))
        tk.MustExec("set tidb_slow_log_threshold=0;")
        tk.MustExec(`prepare mystmt1 from 'select sleep(?), 1';`)
        tk.MustExec("SET @num = 0.01;")
@@ -126,6 +129,7 @@ func TestLogSlowLogIndex(t *testing.T) {
        })
        require.NoError(t, logutil.InitLogger(config.GetGlobalConfig().Log.ToLogConfig()))

+       tk.MustExec(fmt.Sprintf("set @@tidb_slow_query_file='%v'", f.Name()))
        tk.MustExec("use test")
        tk.MustExec("create table t (a int, b int,index idx(a));")
        tk.MustExec("set tidb_slow_log_threshold=0;")
@@ -163,6 +167,7 @@ select * from t;
        }()
        require.NoError(t, logutil.InitLogger(newCfg.Log.ToLogConfig()))

+       tk.MustExec(fmt.Sprintf("set @@tidb_slow_query_file='%v'", f.Name()))
        tk.MustQuery("select count(*) from `information_schema`.`slow_query` where time > '2020-10-16 20:08:13' and time < '2020-10-16 21:08:13'").Check(testkit.Rows("1"))
        tk.MustQuery("select count(*) from `information_schema`.`slow_query` where time > '2019-10-13 20:08:13' and time < '2020-10-16 21:08:13'").Check(testkit.Rows("2"))
 }

[tisonkun]

Thank @crazycs520 and updated.

[sre-bot]

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/34f6365d190926ed693052561bf7c4d1777651d1

[tisonkun]

/cc @crazycs520 @xhebox

[tisonkun]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 2026878

[ti-chi-bot]

@tisonkun: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.