-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools/check: make ut retry on special 'segmentation fault' error (#33566) #33619
Conversation
Signed-off-by: ti-srebot <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@tiancaiamao you're already a collaborator in bot's repo. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/78ceda295ce057494cbf48b456143361630f8ad3 |
PTAL @hawkingrei @wjhuang2016 |
DMR version, closed |
cherry-pick #33566 to release-6.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/33619
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #32690 #32392
Problem Summary:
The 'segmentation fault' panic is weird, there is no more information, just this error message:
https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/43086/artifacts/
I try to debug the panic stack but there is nothing interesting.
It panic on line 53,
gp.m.locks
, the value ofgp.m
is0xe
which is wrong.What is changed and how it works?
I don't know to fix it, so let's just retry in this case to make the CI more stable.
Maybe it's related to DATA RACE, but I'm not sure.
Check List
Tests
Side effects
Documentation
Release note