Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: split and scatter regions in batches #33625

Merged
merged 11 commits into from
Apr 26, 2022
Merged

lightning: split and scatter regions in batches #33625

merged 11 commits into from
Apr 26, 2022

Conversation

sleepymole
Copy link
Contributor

@sleepymole sleepymole commented Mar 31, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #33618

Problem Summary:

Region scatter may timeout when split and scatter many regions at a time.

What is changed and how it works?

Add a batch limit for split and scatter regions. In a batch, lightning processes up to 4096 ranges. After all ranges in batch have been processed completely, lightning can process the next batch.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

I prepared about 1.8T data for a table which contains only one clustered primary key. TiDB cluster have ten TiKV nodes, each node have 200% cpu limit and 16GiB memory limit. Then I used lightning to import these data to TiDB cluster and observed the scatter operator status in grafana dashboard. To reproduce huge amount of regions, I set region-split-size to 8MiB. Finally, about 260k regions were created.

Master
image
Many scatter operator is timeout.

This PR
image

There is no operator timeout after this PR.

  • No code

Release note

lightning: split and scatter regions in batches

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 31, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-6.0 and removed do-not-merge/needs-triage-completed labels Mar 31, 2022
@sleepymole sleepymole added the component/lightning This issue is related to Lightning of TiDB. label Mar 31, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 14, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/c1ae0712575fba6e8cf56b5fe4db6fcfa418a394

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 18, 2022
@sleepymole
Copy link
Contributor Author

/run-unit-test

D3Hunter
D3Hunter reviewed Apr 19, 2022
View reviewed changes
Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

br/pkg/lightning/backend/local/localhelper.go Outdated Show resolved Hide resolved
D3Hunter
D3Hunter approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 21, 2022
@sleepymole sleepymole requested a review from glorv April 21, 2022 09:56
lichunzhu
lichunzhu approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 26, 2022
@sleepymole
Copy link
Contributor Author

/run-integration-br-test

@sleepymole
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bb620a0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2022
@sleepymole
Copy link
Contributor Author

/run-mysql-test

@sleepymole
Copy link
Contributor Author

/run-cla

@ti-chi-bot ti-chi-bot merged commit 2f2fa06 into pingcap:master Apr 26, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 26, 2022
@sleepymole @ti-srebot
cherry pick pingcap#33625 to release-5.3
d4ad24c 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2022
Merged
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #34257

@ti-srebot ti-srebot mentioned this pull request Apr 26, 2022
Merged
4 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 26, 2022
@sleepymole @ti-srebot
cherry pick pingcap#33625 to release-5.4
663a90a 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #34258

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 26, 2022
@sleepymole @ti-srebot
cherry pick pingcap#33625 to release-6.0
993665c 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #34259

@sleepymole sleepymole deleted the issue-33618 branch April 26, 2022 15:25
@sre-bot
Copy link
Contributor

sre-bot commented Apr 26, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 6 min 49 sec New failing
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 11, total 12 6 min 36 sec Existing failure
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 7 min 0 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 18 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 1 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 49 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 47 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

ti-chi-bot pushed a commit that referenced this pull request Jun 15, 2022
@ti-srebot
lightning: split and scatter regions in batches (#33625) (#34257)
0cbc12b 
close #33618
ti-chi-bot pushed a commit that referenced this pull request Jun 27, 2022
@ti-srebot
lightning: split and scatter regions in batches (#33625) (#34258)
d6be910 
close #33618
@rleungx rleungx mentioned this pull request Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lichunzhu lichunzhu lichunzhu approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

@dsdashun dsdashun Awaiting requested review from dsdashun

@glorv glorv Awaiting requested review from glorv

@lance6716 lance6716 Awaiting requested review from lance6716

Assignees
No one assigned
Labels
component/lightning This issue is related to Lightning of TiDB. needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lightning: scatter region timeout when importing a single table with 4.8T data
6 participants
@sleepymole @ti-chi-bot @sre-bot @ti-srebot @D3Hunter @lichunzhu