Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: refactor ddl test for concurrency ddl #33634

Merged
merged 2 commits into from
Mar 31, 2022
Merged

ddl: refactor ddl test for concurrency ddl #33634

merged 2 commits into from
Mar 31, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Mar 31, 2022 •
edited
Loading

Signed-off-by: Weizhen Wang [email protected]

What problem does this PR solve?

Issue Number: ref #33635

Problem Summary:

  • remove the usage of t.Run so that it makes test case isolation.
  • change the scope of the fail point.

it has been passed by #32169

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 31, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tisonkun
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 31, 2022
@hawkingrei hawkingrei added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2022
hawkingrei added a commit to hawkingrei/tidb that referenced this pull request Mar 31, 2022
@hawkingrei
refactor TestAddIndexWorkerNum in pingcap#33634
d2b562b 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue labels Mar 31, 2022
@hawkingrei
Copy link
Member Author

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Mar 31, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9b0b657673518079740de18b4d1444c91cafbd93

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 31, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 31, 2022
@tisonkun
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9b0b657

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 31, 2022
@hawkingrei
Copy link
Member Author

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit e8ac50f into pingcap:master Mar 31, 2022
@hawkingrei hawkingrei deleted the refactor_ddl_test_for_concurrency_ddl branch March 31, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@xiongjiwei xiongjiwei Awaiting requested review from xiongjiwei

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hawkingrei @ti-chi-bot @sre-bot @tisonkun @wjhuang2016