Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: use max_allowed_packet to limit the packet size. #33651

Merged
merged 31 commits into from
Apr 18, 2022
Merged

server: use max_allowed_packet to limit the packet size. #33651

merged 31 commits into from
Apr 18, 2022

Conversation

CbcWestwolf
Copy link
Member

@CbcWestwolf CbcWestwolf commented Apr 1, 2022 •
edited by bb7133
Loading

What problem does this PR solve?

Issue Number: close #31422

Problem Summary:

The max_allowed_packet exists but did not work on previous versions.

What is changed and how it works?

  1. truncate the value of max_allowed_packet if it is not a multiple of 1024
  2. report an error if the accumulated length of a packet is longer than max_allowed_packet

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the issue that system variable `max_allowed_packet` does not work.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • dveeden
  • mjonss

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.0 release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-6.0 size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 1, 2022
@CbcWestwolf CbcWestwolf mentioned this pull request Apr 1, 2022
Closed
12 tasks
@CbcWestwolf
Copy link
Member Author

/cc mjonss dveeden

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 1, 2022
@CbcWestwolf CbcWestwolf requested a review from a team as a code owner April 1, 2022 08:50
@sre-bot
Copy link
Contributor

sre-bot commented Apr 1, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/6fa6e27abdd1df0b79ddaf22545816fccaad07db

mjonss
mjonss approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but if possible please create a function for reuse code instead of copy/paste (see comment in SetSessionFromHook

sessionctx/variable/variable.go Outdated
Comment on lines 192 to 201
u, err := strconv.ParseUint(val, 10, 64)
if err != nil {
return errors.Trace(err)
}
// The value should be a multiple of 1024; nonmultiples are rounded down to the nearest multiple.
if u%1024 != 0 {
s.StmtCtx.AppendWarning(ErrTruncatedWrongValue.GenWithStackByArgs(MaxAllowedPacket, val))
u = (u / 1024) * 1024
val = strconv.FormatUint(u, 10)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a function and reuse the same code here and in SetGlobalSysVar.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 1, 2022
@hawkingrei
Copy link
Member

/merge

@CbcWestwolf
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2022
@CbcWestwolf
Copy link
Member Author

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 4d3a3c2 into pingcap:master Apr 18, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 18, 2022
@CbcWestwolf @ti-srebot
cherry pick pingcap#33651 to release-5.0
446452e 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 18, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #34053

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 18, 2022
@CbcWestwolf @ti-srebot
cherry pick pingcap#33651 to release-5.1
134db37 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 18, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #34054

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 18, 2022
@CbcWestwolf @ti-srebot
cherry pick pingcap#33651 to release-5.2
e36634c 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 18, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #34055

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 18, 2022
@CbcWestwolf @ti-srebot
cherry pick pingcap#33651 to release-5.3
6a677b0 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 18, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #34056

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 18, 2022
@CbcWestwolf @ti-srebot
cherry pick pingcap#33651 to release-5.4
562dcd5 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 18, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #34057

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 18, 2022
@CbcWestwolf @ti-srebot
cherry pick pingcap#33651 to release-6.0
a6c05a4 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 18, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #34059

@sre-bot
Copy link
Contributor

sre-bot commented Apr 18, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 1, success 10, total 11 11 min New failing
idc-jenkins-ci-tidb/common-test 🟥 failed 1, success 11, total 12 6 min 47 sec New failing
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 7 min 35 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 52 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 14 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 40 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 4 min 59 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 50 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@CbcWestwolf CbcWestwolf deleted the max_allowed_packet branch April 18, 2022 04:45
This was referenced Apr 18, 2022
Closed
Open
@morgo morgo mentioned this pull request May 24, 2022
Closed
@tiancaiamao
Copy link
Contributor

max_allowed_packet is the max allowed packet size of a packet, not the accumulated size of the all received data. @CbcWestwolf

See https://dev.mysql.com/doc/refman/8.0/en/packet-too-large.html

This was referenced Sep 29, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjonss mjonss mjonss approved these changes

@dveeden dveeden dveeden approved these changes

@bb7133 bb7133 bb7133 approved these changes

@morgo morgo Awaiting requested review from morgo

Assignees
No one assigned
Labels
compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

max_allowed_packet length is set to 1024 but its not working for string length.