Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn: fix invalid transaction error when doing stale read in RC isolation level (#33653) #33663

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 2, 2022

cherry-pick #33653 to release-6.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/33663

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/33663:release-6.0-ec637878d4ca

What problem does this PR solve?

Issue Number: close #30872

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

fix `invalid transaction` error when doing stale read in RC isolation level

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 2, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 2, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Apr 2, 2022
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/6.0-cherry-pick labels Apr 2, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 2, 2022

1 similar comment
@sre-bot
Copy link
Contributor

sre-bot commented Apr 2, 2022

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 2, 2022
@xhebox
Copy link
Contributor

xhebox commented Aug 2, 2022

Since it is a DNM, closed

/closed

@xhebox xhebox closed this Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. type/6.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants