Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: enhance request log in server-mode and restore progress #33718

Merged
merged 10 commits into from
Apr 18, 2022
Merged

lightning: enhance request log in server-mode and restore progress #33718

merged 10 commits into from
Apr 18, 2022

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Apr 6, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #33715

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • import using server-mode, check log and progress
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 6, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gozssky
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 6, 2022
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 6, 2022

component/lightning

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 6, 2022

/component lightning

@ti-chi-bot ti-chi-bot added the component/lightning This issue is related to Lightning of TiDB. label Apr 6, 2022
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 6, 2022

/cc @gozssky @lance6716

@sre-bot
Copy link
Contributor

sre-bot commented Apr 6, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/7149e02d99bd0e304520d435633db3884a480ded

lance6716
lance6716 reviewed Apr 6, 2022
View reviewed changes
br/pkg/lightning/restore/restore.go
} else {
for _, eng := range cp.Engines {
for _, chunk := range eng.Chunks {
totalDataSizeToRestore += chunk.Chunk.EndOffset - chunk.Chunk.Offset
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems when task is paused and resumed, we'll use unfinished bytes to calculate progress. This will display a 0% progress when resuming, which makes me think that the resuming is failed and we're starting from scratch 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's consistent to previous impl, cal progress from current checkpoint, not from the datafile begin.

sleepymole
sleepymole reviewed Apr 11, 2022
View reviewed changes
br/pkg/lightning/metric/metric.go Show resolved Hide resolved
br/pkg/lightning/restore/restore.go Show resolved Hide resolved
br/pkg/lightning/restore/restore.go Show resolved Hide resolved
br/pkg/lightning/restore/restore.go Show resolved Hide resolved
@sleepymole
Copy link
Contributor

/run-integration-br-test

1 similar comment
@D3Hunter
Copy link
Contributor Author

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

ping @gozssky

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 14, 2022
@D3Hunter
Copy link
Contributor Author

ping @lance6716

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 15, 2022
@D3Hunter
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@D3Hunter: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 18, 2022 •
edited
Loading

@lance6716 help with merge

@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ff70519

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 18, 2022
@ti-chi-bot ti-chi-bot merged commit fbb497f into pingcap:master Apr 18, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 18, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 1, success 10, total 11 13 min New failing
idc-jenkins-ci-tidb/sqllogic-test-1 🟥 failed 1, success 25, total 26 7 min 23 sec New failing
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 11, total 12 7 min 6 sec Existing failure
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 8 min 12 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 7 min 55 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 50 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 6 min 33 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 4 min 29 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@D3Hunter D3Hunter deleted the fix-log-and-progress branch April 18, 2022 12:23
@sleepymole sleepymole mentioned this pull request Apr 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@sleepymole sleepymole sleepymole approved these changes

Assignees
No one assigned
Labels
component/lightning This issue is related to Lightning of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enchance progress and log when receive http request
5 participants
@D3Hunter @ti-chi-bot @sre-bot @sleepymole @lance6716