Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Refactor session#domainMap use RWMutex to replace Mutex #33739

Merged
merged 3 commits into from
Apr 6, 2022
Merged

*: Refactor session#domainMap use RWMutex to replace Mutex #33739

merged 3 commits into from
Apr 6, 2022

Conversation

likzn
Copy link
Contributor

@likzn likzn commented Apr 6, 2022

What problem does this PR solve?

Issue Number: close #33737

Problem Summary: Improve the performance of session#domainMap func of Get()

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@likzn
Update tidb.go
bfb3243 
opt:use rwmutex to replace mutex
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 6, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 6, 2022
@ti-chi-bot
Copy link
Member

Welcome @likzn!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

@CLAassistant
Copy link

CLAassistant commented Apr 6, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@likzn likzn changed the title *:Refactor session#domainMap use RWMutex replace Mutex #1 *:Refactor session#domainMap use RWMutex to replace Mutex Apr 6, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 6, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@sre-bot
Copy link
Contributor

sre-bot commented Apr 6, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/bdfc31c4515d8637f70c15e8bd39a702088ec4b9

@likzn likzn changed the title *:Refactor session#domainMap use RWMutex to replace Mutex *: Refactor session#domainMap use RWMutex to replace Mutex Apr 6, 2022
@likzn
Copy link
Contributor Author

likzn commented Apr 6, 2022

/run-check_title

xhebox
xhebox approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but one comment.

This does not make much difference since domap is not used frequently anyway.. It is rarely used.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 6, 2022
@xhebox
Copy link
Contributor

xhebox commented Apr 6, 2022

@likzn SIgn CLA BTW

@likzn
Copy link
Contributor Author

likzn commented Apr 6, 2022

/run-mysql-test

@likzn
Copy link
Contributor Author

likzn commented Apr 6, 2022

/run-check-license

@likzn
Copy link
Contributor Author

likzn commented Apr 6, 2022

@likzn SIgn CLA BTW

@xhebox I had signed just now. And I see a check-linsece in the workflow, but it dont start yet. And there is no "Details" button. What should I do..

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 6, 2022
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bdfc31c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 6, 2022
@ti-chi-bot ti-chi-bot merged commit 967d203 into pingcap:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

session#domainMap use RWMutex replace Mutex
6 participants
@likzn @ti-chi-bot @CLAassistant @sre-bot @xhebox @hawkingrei