Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/ddl-checker: fix DATA RACE in TestExecute #33781

Merged
merged 3 commits into from
Apr 7, 2022

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Apr 7, 2022

What problem does this PR solve?

Issue Number: close #33701

Problem Summary:

What is changed and how it works?

The Exec() result should be closed, otherwise the background coprocessor goroutine is running,
it would DATA RACE with the next Exec().

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

After #33765, you can verify it with

make ut X='run util/ddl-checker TestExecute --race'

Before:

#33752 (comment)

After:

make ut X='run util/ddl-checker TestExecute --race'
tools/bin/ut run util/ddl-checker TestExecute --race || { find $PWD/ -type d | grep -vE "(\.git|tools)" | xargs tools/bin/failpoint-ctl disable; exit 1; }
2022/04/07 16:57:28 maxprocs: Leaving GOMAXPROCS=16: CPU quota undefined
building task finish, count=1, takes=7.317796473s
run all tasks takes 939.7532ms
  • [] No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 7, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • ngaut

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 7, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 7, 2022

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 7, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 7, 2022
@Defined2014
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d6b410c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2022
@ti-chi-bot ti-chi-bot merged commit 942f4d1 into pingcap:master Apr 7, 2022
@tiancaiamao tiancaiamao deleted the race-33701 branch April 13, 2022 01:45
@tiancaiamao
Copy link
Contributor Author

Close #33766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DATA RACE in the TableReaderExecutor
6 participants