-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: update as option #338
Conversation
select field alias can support back/double/single quote
TableAsOpt: | ||
identifier | ||
{ | ||
// TODO: check potential bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this?
TableAsOpt: | ||
Identifier | ||
{ | ||
// TODO: check potential bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shenli Can u remember why we add this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am also confused....
LGTM |
1 similar comment
LGTM |
* optimize local backend * update some config * update batch size * fix type in config.toml and tidy go.mod * update tools failpoint * fix session * update test config * reset default batch size for not-local backend * reset batch-size for example toml
* update pushdown blacklist Signed-off-by: David <[email protected]> * fmt Signed-off-by: David <[email protected]> --------- Signed-off-by: David <[email protected]> Co-authored-by: zzm <[email protected]>
select field alias can support back/double/single quote
fix #323